Re: [PATCH] fs: push file_update_time into -page_mkwrite

2011-12-20 Thread Dave Chinner
On Tue, Nov 29, 2011 at 04:50:20PM +0100, Jan Kara wrote: On Tue 29-11-11 10:40:59, Josef Bacik wrote: The fault code has been calling file_update_time after -page_mkwrite after it drops the page lock, but this is annoying because this calls mark_inode_dirty which can fail in Btrfs,

[PATCH] fs: push file_update_time into -page_mkwrite

2011-11-29 Thread Josef Bacik
The fault code has been calling file_update_time after -page_mkwrite after it drops the page lock, but this is annoying because this calls mark_inode_dirty which can fail in Btrfs, so we want to be able to do these updates in -page_mkwrite so we can get an error back to the user. So get rid of

Re: [PATCH] fs: push file_update_time into -page_mkwrite

2011-11-29 Thread Jan Kara
On Tue 29-11-11 10:40:59, Josef Bacik wrote: The fault code has been calling file_update_time after -page_mkwrite after it drops the page lock, but this is annoying because this calls mark_inode_dirty which can fail in Btrfs, so we want to be able to do these updates in -page_mkwrite so we can

Re: [PATCH] fs: push file_update_time into -page_mkwrite

2011-11-29 Thread Josef Bacik
On Tue, Nov 29, 2011 at 04:50:20PM +0100, Jan Kara wrote: On Tue 29-11-11 10:40:59, Josef Bacik wrote: The fault code has been calling file_update_time after -page_mkwrite after it drops the page lock, but this is annoying because this calls mark_inode_dirty which can fail in Btrfs,