Re: [PATCH] fstests: btrfs: add test for quota groups and drop snapshot

2015-10-01 Thread Mark Fasheh
On Tue, Sep 29, 2015 at 09:28:58AM +1000, Dave Chinner wrote: > On Wed, Sep 23, 2015 at 02:05:16PM -0700, Mark Fasheh wrote: > > Since the last time I sent this test, drop snapshot was broken again with > > respect to qgroups. What practical step could I take to get a test for that > > in here whic

Re: [PATCH] fstests: btrfs: add test for quota groups and drop snapshot

2015-09-28 Thread Dave Chinner
On Wed, Sep 23, 2015 at 02:05:16PM -0700, Mark Fasheh wrote: > Since the last time I sent this test, drop snapshot was broken again with > respect to qgroups. What practical step could I take to get a test for that > in here which I can beat the btrfs developers over the head with the next > time s

Re: [PATCH] fstests: btrfs: add test for quota groups and drop snapshot

2015-09-23 Thread Mark Fasheh
Hey Dave, thanks for the review. A refreshed patch for you to look at is attached. On Wed, Sep 23, 2015 at 12:47:08PM +1000, Dave Chinner wrote: > On Tue, Sep 22, 2015 at 03:16:49PM -0700, Mark Fasheh wrote: > > +tmp=/tmp/$$ > > +status=1 # failure is the default! > > +trap "_cleanup; exit \$sta

Re: [PATCH] fstests: btrfs: add test for quota groups and drop snapshot

2015-09-22 Thread Dave Chinner
On Tue, Sep 22, 2015 at 03:16:49PM -0700, Mark Fasheh wrote: > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + rm -fr $tmp > +} Missing a "cd /" (see the "new" template). > +# Create an fs tree of a given height at

[PATCH] fstests: btrfs: add test for quota groups and drop snapshot

2015-09-22 Thread Mark Fasheh
Test btrfs quota group consistency operations during snapshot delete. Btrfs has had long standing issues with drop snapshot failing to properly account for quota groups. This test crafts several snapshot trees with shared and exclusive elements. One of the trees is removed and then quota group cons