Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V2

2013-08-29 Thread Eric Sandeen
On 8/29/13 8:21 AM, David Sterba wrote: > On Tue, Aug 13, 2013 at 02:38:05PM -0500, Eric Sandeen wrote: >>> +. ./common/rc >>> +. ./common/filter >>> + >>> +# real QA test starts here >>> +_supported_fs btrfs >>> +_supported_os Linux >>> +_require_scratch >>> + >>> +_scratch_mkfs > /dev/null 2>&1 >

Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V2

2013-08-29 Thread David Sterba
On Tue, Aug 13, 2013 at 02:38:05PM -0500, Eric Sandeen wrote: > > +. ./common/rc > > +. ./common/filter > > + > > +# real QA test starts here > > +_supported_fs btrfs > > +_supported_os Linux > > +_require_scratch > > + > > +_scratch_mkfs > /dev/null 2>&1 > > +_scratch_mount > > + > > +# This will

Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V3

2013-08-14 Thread Rich Johnston
On 08/14/2013 03:07 PM, Josef Bacik wrote: We were allowing users to delete their default subvolume, which is problematic. This test is a regression test to make sure we don't let that happen in the future. Thanks, Signed-off-by: Josef Bacik --- V2->V3: remove comment and abstract out the subv

Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V3

2013-08-14 Thread Eric Sandeen
On 8/14/13 3:07 PM, Josef Bacik wrote: > We were allowing users to delete their default subvolume, which is > problematic. > This test is a regression test to make sure we don't let that happen in the > future. Thanks, > > Signed-off-by: Josef Bacik > --- > V2->V3: remove comment and abstract o

[PATCH] xfstests: btrfs/003: regression test for subvol delete V3

2013-08-14 Thread Josef Bacik
We were allowing users to delete their default subvolume, which is problematic. This test is a regression test to make sure we don't let that happen in the future. Thanks, Signed-off-by: Josef Bacik --- V2->V3: remove comment and abstract out the subvolid logic as per Eric's suggestions V1->V2

Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V2

2013-08-13 Thread Eric Sandeen
On 8/13/13 2:34 PM, Josef Bacik wrote: > We were allowing users to delete their default subvolume, which is > problematic. > This test is a regression test to make sure we don't let that happen in the > future. Thanks, > > Signed-off-by: Josef Bacik > --- > V1->V2: address the comments made by

[PATCH] xfstests: btrfs/003: regression test for subvol delete V2

2013-08-13 Thread Josef Bacik
We were allowing users to delete their default subvolume, which is problematic. This test is a regression test to make sure we don't let that happen in the future. Thanks, Signed-off-by: Josef Bacik --- V1->V2: address the comments made by Eric Sandeen. tests/btrfs/003 | 66 +

Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete

2013-08-12 Thread Eric Sandeen
On 8/12/13 2:40 PM, Josef Bacik wrote: > We were allowing users to delete their default subvolume, which is > problematic. > This test is a regression test to make sure we don't let that happen in the > future. Thanks, > > Signed-off-by: Josef Bacik > --- > tests/btrfs/003 | 64 > ++

[PATCH] xfstests: btrfs/003: regression test for subvol delete

2013-08-12 Thread Josef Bacik
We were allowing users to delete their default subvolume, which is problematic. This test is a regression test to make sure we don't let that happen in the future. Thanks, Signed-off-by: Josef Bacik --- tests/btrfs/003 | 64 +++ tests/btrfs/