[PATCH] xfstests: generic/315: add one more sync and more output

2013-07-29 Thread Josef Bacik
So df in btrfs is tricky at best, and relying on it for accurate information is not great, but it's the best way to verify this test. So we need to add another sync to make sure the pinned blocks are all freed up and the df space is really really accurate, otherwise we end up with this test

Re: [PATCH] xfstests: generic/315: add one more sync and more output

2013-07-29 Thread Eric Sandeen
On 7/29/13 12:21 PM, Josef Bacik wrote: So df in btrfs is tricky at best, and relying on it for accurate information is not great, but it's the best way to verify this test. So we need to add another sync to make sure the pinned blocks are all freed up and the df space is really really

Re: [PATCH] xfstests: generic/315: add one more sync and more output

2013-07-29 Thread Eric Sandeen
On 7/29/13 12:31 PM, Eric Sandeen wrote: Honest question: does one more sync make this deterministic, or is it a best-effort, um, hack? I'm not quite sure why even 1 sync is needed. :( I'm not sure what bug this is trying to test; if you need 2 syncs for global space stats to accurately

Re: [PATCH] xfstests: generic/315: add one more sync and more output

2013-07-29 Thread Josef Bacik
On Mon, Jul 29, 2013 at 12:38:25PM -0500, Eric Sandeen wrote: On 7/29/13 12:31 PM, Eric Sandeen wrote: Honest question: does one more sync make this deterministic, or is it a best-effort, um, hack? I'm not quite sure why even 1 sync is needed. :( Because of COW, we won't free up the