Re: [PATCH] xfstests: kill lib/random.c

2014-01-12 Thread Dave Chinner
On Tue, Jan 07, 2014 at 09:20:12PM +, Chris Mason wrote: On Tue, 2014-01-07 at 16:17 -0500, Josef Bacik wrote: On 01/07/2014 03:40 PM, Ben Myers wrote: On Tue, Jan 07, 2014 at 02:10:15PM -0600, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Ben Myers
Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying to reproduce something with fsx and I noticed that no matter what seed I

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Eric Sandeen
On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying to reproduce something with fsx and I

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Eric Sandeen
On 1/7/14, 2:10 PM, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying to

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Josef Bacik
On 01/07/2014 03:10 PM, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Ben Myers
On Tue, Jan 07, 2014 at 02:10:15PM -0600, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Josef Bacik
On 01/07/2014 03:40 PM, Ben Myers wrote: On Tue, Jan 07, 2014 at 02:10:15PM -0600, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen

Re: [PATCH] xfstests: kill lib/random.c

2014-01-07 Thread Chris Mason
On Tue, 2014-01-07 at 16:17 -0500, Josef Bacik wrote: On 01/07/2014 03:40 PM, Ben Myers wrote: On Tue, Jan 07, 2014 at 02:10:15PM -0600, Eric Sandeen wrote: On 1/7/14, 2:01 PM, Ben Myers wrote: Hey Gents, On Mon, Jan 06, 2014 at 03:46:58PM -0600, Eric Sandeen wrote: On 1/6/14, 3:42

[PATCH] xfstests: kill lib/random.c

2014-01-06 Thread Josef Bacik
I was trying to reproduce something with fsx and I noticed that no matter what seed I set I was getting the same file. Come to find out we are overloading random() with our own custom horribleness for some unknown reason. So nuke the damn thing from orbit and rely on glibc's random(). With this

Re: [PATCH] xfstests: kill lib/random.c

2014-01-06 Thread Eric Sandeen
On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying to reproduce something with fsx and I noticed that no matter what seed I set I was getting the same file. Come to find out we are overloading random() with our own custom horribleness for some unknown reason. So nuke the damn thing from

Re: [PATCH] xfstests: kill lib/random.c

2014-01-06 Thread Josef Bacik
On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying to reproduce something with fsx and I noticed that no matter what seed I set I was getting the same file. Come to find out we are overloading random() with our own custom horribleness for some

Re: [PATCH] xfstests: kill lib/random.c

2014-01-06 Thread Eric Sandeen
On 1/6/14, 3:42 PM, Josef Bacik wrote: On 01/06/2014 04:32 PM, Eric Sandeen wrote: On 1/6/14, 1:58 PM, Josef Bacik wrote: I was trying to reproduce something with fsx and I noticed that no matter what seed I set I was getting the same file. Come to find out we are overloading random()