Re: [PATCH 0/2] btrfs device remove alias

2015-06-27 Thread Goffredo Baroncelli
On 2015-06-26 15:33, David Sterba wrote: > On Fri, Jun 26, 2015 at 09:10:56AM +0800, Anand Jain wrote: >> while on this. its also good idea to create alias for >> >>btrfs replace start -> btrfs device replace. > > This was asked for back then, and briefly discussed on irc (11/2012). > The pref

Re: [PATCH 0/2] btrfs device remove alias

2015-06-26 Thread David Sterba
On Fri, Jun 26, 2015 at 09:10:56AM +0800, Anand Jain wrote: > while on this. its also good idea to create alias for > >btrfs replace start -> btrfs device replace. This was asked for back then, and briefly discussed on irc (11/2012). The preference was not to do too much typing, although the

Re: [PATCH 0/2] btrfs device remove alias

2015-06-25 Thread Duncan
Anand Jain posted on Fri, 26 Jun 2015 09:10:56 +0800 as excerpted: > while on this. its also good idea to create alias for > >btrfs replace start -> btrfs device replace. > > any comments ? That's actually the one that makes more sense to me. Delete/remove/ subtract, all about the same to

Re: [PATCH 0/2] btrfs device remove alias

2015-06-25 Thread Anand Jain
while on this. its also good idea to create alias for btrfs replace start -> btrfs device replace. any comments ? On 06/25/2015 12:09 AM, Omar Sandoval wrote: The opposite of btrfs device add is btrfs device delete. This really should be btrfs device remove. Changes from v1: - Add support

Re: [PATCH 0/2] btrfs device remove alias

2015-06-25 Thread Chris Mason
On Thu, Jun 25, 2015 at 03:41:51PM +0200, David Sterba wrote: > On Wed, Jun 24, 2015 at 09:09:15AM -0700, Omar Sandoval wrote: > > The opposite of btrfs device add is btrfs device delete. This really > > should be btrfs device remove. > > I think people got used to the 'delete' command over time,

Re: [PATCH 0/2] btrfs device remove alias

2015-06-25 Thread David Sterba
On Wed, Jun 24, 2015 at 09:09:15AM -0700, Omar Sandoval wrote: > The opposite of btrfs device add is btrfs device delete. This really > should be btrfs device remove. I think people got used to the 'delete' command over time, but for convenience I don't mind to add the alias. Also you delete files

Re: [PATCH 0/2] btrfs device remove alias

2015-06-24 Thread Duncan
Omar Sandoval posted on Wed, 24 Jun 2015 09:09:15 -0700 as excerpted: > The opposite of btrfs device add is btrfs device delete. This really > should be btrfs device remove. What about btrfs device subtract? That's what _I_'d call the opposite of add. Otherwise, add/remove instead of add/delet

[PATCH 0/2] btrfs device remove alias

2015-06-24 Thread Omar Sandoval
The opposite of btrfs device add is btrfs device delete. This really should be btrfs device remove. Changes from v1: - Add support for flags to cmd_struct and a CMD_ALIAS flag which only prints the one-line usage string - Rearrange the command wrappers in a way that could be made generic if ne