Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Mike Fedyk
On Thu, Feb 18, 2010 at 12:58 PM, Chris Mason wrote: > On Thu, Feb 18, 2010 at 12:46:56PM -0800, Mike Fedyk wrote: >> On Thu, Feb 18, 2010 at 11:59 AM, Goffredo Baroncelli >> wrote: >> > On Thursday 18 February 2010, Chris Mason wrote: >> >> I do like the subcommand method, more details below. >>

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Tomasz Torcz
On Thu, Feb 18, 2010 at 12:46:56PM -0800, Mike Fedyk wrote: > btrfs defrag file > btrfs defrag directory > btrfs defrag subvol > btrfs defrag pool I think this could be implied by , so it will be better to drop 3rd word: btrfs defrag /this/file btrfs defrag /mnt/btrfs/somedir/ btrfs defrag

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Goffredo Baroncelli
On Thursday 18 February 2010, Chris Mason wrote: > On Thu, Feb 18, 2010 at 12:46:56PM -0800, Mike Fedyk wrote: > > On Thu, Feb 18, 2010 at 11:59 AM, Goffredo Baroncelli > > wrote: > > > On Thursday 18 February 2010, Chris Mason wrote: > > >> I do like the subcommand method, more details below. > >

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Goffredo Baroncelli
On Thursday 18 February 2010, Chris Mason wrote: > I do like the subcommand method, more details below. > > On Wed, Feb 17, 2010 at 03:35:26PM -0800, Mike Fedyk wrote: > > I think he need some command hierarchy here. > > > > On Wed, Feb 17, 2010 at 12:02 PM, Goffredo Baroncelli > > wrote: > > >

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Chris Mason
On Thu, Feb 18, 2010 at 12:46:56PM -0800, Mike Fedyk wrote: > On Thu, Feb 18, 2010 at 11:59 AM, Goffredo Baroncelli > wrote: > > On Thursday 18 February 2010, Chris Mason wrote: > >> I do like the subcommand method, more details below. > >> > > > > I try to summarise your suggestions. But there ar

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Mike Fedyk
On Thu, Feb 18, 2010 at 11:59 AM, Goffredo Baroncelli wrote: > On Thursday 18 February 2010, Chris Mason wrote: >> I do like the subcommand method, more details below. >> > > I try to summarise your suggestions. But there are some cases not to clear for > me. > I grouped the commands in three cate

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Goffredo Baroncelli
On Thursday 18 February 2010, Chris Mason wrote: > I do like the subcommand method, more details below. > I try to summarise your suggestions. But there are some cases not to clear for me. I grouped the commands in three categories: subvolume, devices, and filesystem. devices scan de

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Thomas Kupper
I'm happy that I'm not alone with my preference for subcommands :) over short - commands. Btw: I think it would be a good idea start from the beginning with a 'libbtrfs' library and a corresponding API. That way integrating into other languages like Python and integration into tools like parted

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Mike Fedyk
On Thu, Feb 18, 2010 at 8:58 AM, Chris Mason wrote: > I do like the subcommand method, more details below. > > On Wed, Feb 17, 2010 at 03:35:26PM -0800, Mike Fedyk wrote: >> I think he need some command hierarchy here. >> >> On Wed, Feb 17, 2010 at 12:02 PM, Goffredo Baroncelli >> wrote: >> > OPT

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Chris Mason
I do like the subcommand method, more details below. On Wed, Feb 17, 2010 at 03:35:26PM -0800, Mike Fedyk wrote: > I think he need some command hierarchy here. > > On Wed, Feb 17, 2010 at 12:02 PM, Goffredo Baroncelli > wrote: > > OPTIONS > >       snapshot|-s [/] > >              Create a writ

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-18 Thread Piavlo
Hi, I agree with Mike, it's just much much more pleasant and intuitive to work with the hierarchyial cli he suggests. Alex Mike Fedyk wrote: > I think he need some command hierarchy here. > > On Wed, Feb 17, 2010 at 12:02 PM, Goffredo Baroncelli > wrote: > >> OPTIONS >> snapshot|-s

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-17 Thread Mike Fedyk
I think he need some command hierarchy here. On Wed, Feb 17, 2010 at 12:02 PM, Goffredo Baroncelli wrote: > OPTIONS >       snapshot|-s [/] >              Create a writeble snapshot of the subvolume    with  the >              name    in the directory. If is not a sub‐ >              volume, b

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-17 Thread Goffredo Baroncelli
On Wednesday 17 February 2010, you (Andreas Philipp) wrote: > > Andreas Philipp Thank you, I corrected my source and updated the changes to the public repository. -- gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512 -

Re: [PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-17 Thread Andreas Philipp
Hi, Cool tool. Just looking at the help output on the console I found a small typo. Kind regards, Andreas Philipp diff --git a/btrfs.c b/btrfs.c index cc55599..f3e5d8d 100644 --- a/btrfs.c +++ b/btrfs.c @@ -633,7 +633,7 @@ static struct Command commands[] = { "Add a device to a f

[PATCH 0/2 V2] btrfs: a new tool to manage a btrfs filesystem

2010-02-17 Thread Goffredo Baroncelli
Hi all, enclosed in the next two emails you can find two patches which introduce a new program called "btrfs". This program has the ambitious to replace the utilities of the btrfs-prog package, like: - btrfsctl - btrfs-show - btrfs-volume - btrfs The goals are: - improve the usability of the to