Re: [PATCH 0/4] btrfs: offline dedupe v2

2013-06-17 Thread Mark Fasheh
On Wed, Jun 12, 2013 at 02:10:37PM -0400, Josef Bacik wrote: > On Tue, Jun 11, 2013 at 02:31:34PM -0600, Mark Fasheh wrote: > > Hi, > > > > The following series of patches implements in btrfs an ioctl to do > > offline deduplication of file extents. > > Ok I'm relatively happy with this set, I ju

Re: [PATCH 0/4] btrfs: offline dedupe v2

2013-06-12 Thread Josef Bacik
On Tue, Jun 11, 2013 at 02:31:34PM -0600, Mark Fasheh wrote: > Hi, > > The following series of patches implements in btrfs an ioctl to do > offline deduplication of file extents. > > To be clear, "offline" in this sense means that the file system is > mounted and running, but the dedupe is not do

Re: [PATCH 0/4] btrfs: offline dedupe v2

2013-06-11 Thread Mark Fasheh
On Tue, Jun 11, 2013 at 11:31:41PM +0200, Gabriel de Perthuis wrote: > Le 11/06/2013 23:04, Mark Fasheh a écrit : > > On Tue, Jun 11, 2013 at 10:56:59PM +0200, Gabriel de Perthuis wrote: > >>> What I found however is that neither of these is a great idea ;) > >>> > >>> - We want to require that the

Re: [PATCH 0/4] btrfs: offline dedupe v2

2013-06-11 Thread Gabriel de Perthuis
Le 11/06/2013 23:04, Mark Fasheh a écrit : > On Tue, Jun 11, 2013 at 10:56:59PM +0200, Gabriel de Perthuis wrote: >>> What I found however is that neither of these is a great idea ;) >>> >>> - We want to require that the inode be open for writing so that an >>> unprivileged user can't do things l

Re: [PATCH 0/4] btrfs: offline dedupe v2

2013-06-11 Thread Mark Fasheh
On Tue, Jun 11, 2013 at 10:56:59PM +0200, Gabriel de Perthuis wrote: > > What I found however is that neither of these is a great idea ;) > > > > - We want to require that the inode be open for writing so that an > > unprivileged user can't do things like run dedupe on a performance > > sensit

Re: [PATCH 0/4] btrfs: offline dedupe v2

2013-06-11 Thread Gabriel de Perthuis
Le 11/06/2013 22:31, Mark Fasheh a écrit : > Perhaps this isn't a limiation per-se but extent-same requires read/write > access to the files we want to dedupe. During my last series I had a > conversation with Gabriel de Perthuis about access checking where we tried > to maintain the ability for a

[PATCH 0/4] btrfs: offline dedupe v2

2013-06-11 Thread Mark Fasheh
Hi, The following series of patches implements in btrfs an ioctl to do offline deduplication of file extents. To be clear, "offline" in this sense means that the file system is mounted and running, but the dedupe is not done during file writes, but after the fact when some userspace software init