Re: [PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-24 Thread Qu Wenruo
Mark Fasheh wrote on 2015/09/22 13:15 -0700: Hi, The following 4 patches fix a regression introduced in Linux 4.2 where btrfs_drop_snapshot() wasn't updating qgroups, resulting in them going bad. The original e-mail pointing this out is below: http://www.spinics.net/lists/linux-btrfs/msg4609

Re: [PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-23 Thread Qu Wenruo
Mark Fasheh wrote on 2015/09/23 14:49 -0700: On Wed, Sep 23, 2015 at 09:40:42AM +0800, Qu Wenruo wrote: Thanks for all your work on this. Comment on test case is inlined below. No problem, thanks for the review Qu! +# Create an fs tree of a given height at a target location. This is +# do

Re: [PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-23 Thread Duncan
Mark Fasheh posted on Wed, 23 Sep 2015 14:49:26 -0700 as excerpted: > On Wed, Sep 23, 2015 at 09:40:42AM +0800, Qu Wenruo wrote: >> >> I'd prefer a more accurate calculation based on nodesize. >> That would allow using any possible nodesize. > > How do we query nodesize? 'btrfs fi show' doesn't

Re: [PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-23 Thread Mark Fasheh
On Wed, Sep 23, 2015 at 11:58:57AM +0800, Qu Wenruo wrote: > Hi Mark, > > I'd like to test the patchset, but it seems to be a little out of > date, and failed to apply to integration-4.3. > > Would you please rebase it to integration-4.3? Hey Qu I think you just need to drop the patch titled:

Re: [PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-23 Thread Mark Fasheh
On Wed, Sep 23, 2015 at 09:40:42AM +0800, Qu Wenruo wrote: > Thanks for all your work on this. > Comment on test case is inlined below. No problem, thanks for the review Qu! > >+# Create an fs tree of a given height at a target location. This is > >+# done by agressively creating inline extents

Re: [PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-23 Thread Holger Hoffstätte
On 09/23/15 05:58, Qu Wenruo wrote: > I'd like to test the patchset, but it seems to be a little out of > date, and failed to apply to integration-4.3. The first two patches were already merged yesterday, so if you just skip those you should get further. -h -- To unsubscribe from this list: send

Re: [PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-22 Thread Qu Wenruo
Hi Mark, I'd like to test the patchset, but it seems to be a little out of date, and failed to apply to integration-4.3. Would you please rebase it to integration-4.3? Thanks, Qu Mark Fasheh wrote on 2015/09/22 13:15 -0700: Hi, The following 4 patches fix a regression introduced in Linux 4

Re: [PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-22 Thread Qu Wenruo
Hi Mark, Thanks for all your work on this. Comment on test case is inlined below. Mark Fasheh wrote on 2015/09/22 14:12 -0700: On Tue, Sep 22, 2015 at 01:15:44PM -0700, Mark Fasheh wrote: The entire patch series can be tested with the following xfstests.git patch, which will be sent to the app

Re: [PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-22 Thread Mark Fasheh
On Tue, Sep 22, 2015 at 01:15:44PM -0700, Mark Fasheh wrote: > The entire patch series can be tested with the following xfstests.git > patch, which will be sent to the appropriate list shortly) > > https://github.com/markfasheh/xfstests/commit/b09ca51c012824e44546b13862ab1f93a6f2f675 That xfstest

[PATCH 0/4] btrfs: update qgroups in drop snapshot

2015-09-22 Thread Mark Fasheh
Hi, The following 4 patches fix a regression introduced in Linux 4.2 where btrfs_drop_snapshot() wasn't updating qgroups, resulting in them going bad. The original e-mail pointing this out is below: http://www.spinics.net/lists/linux-btrfs/msg46093.html The first two patches are from Josef and