Re: [PATCH 01/19] bitmap: genericize percpu bitmap region iterators

2019-10-15 Thread Dennis Zhou
On Tue, Oct 15, 2019 at 02:11:02PM +0200, David Sterba wrote: > On Mon, Oct 07, 2019 at 06:24:19PM -0400, Dennis Zhou wrote: > > > > + * Bitmap region iterators. Iterates over the bitmap between [@start, > > > > @end). > > > > > > Gonna be that guy here, should be '[@start, @end]' > > > > I dis

Re: [PATCH 01/19] bitmap: genericize percpu bitmap region iterators

2019-10-15 Thread David Sterba
On Mon, Oct 07, 2019 at 06:24:19PM -0400, Dennis Zhou wrote: > > > + * Bitmap region iterators. Iterates over the bitmap between [@start, > > > @end). > > > > Gonna be that guy here, should be '[@start, @end]' > > I disagree here. I'm pretty happy with [@start, @end). If btrfs wants to > carry

Re: [PATCH 01/19] bitmap: genericize percpu bitmap region iterators

2019-10-07 Thread Dennis Zhou
On Mon, Oct 07, 2019 at 04:26:13PM -0400, Josef Bacik wrote: > On Mon, Oct 07, 2019 at 04:17:32PM -0400, Dennis Zhou wrote: > > Bitmaps are fairly popular for their space efficiency, but we don't have > > generic iterators available. Make percpu's bitmap region iterators > > available to everyone.

Re: [PATCH 01/19] bitmap: genericize percpu bitmap region iterators

2019-10-07 Thread Josef Bacik
On Mon, Oct 07, 2019 at 04:17:32PM -0400, Dennis Zhou wrote: > Bitmaps are fairly popular for their space efficiency, but we don't have > generic iterators available. Make percpu's bitmap region iterators > available to everyone. > > Signed-off-by: Dennis Zhou > --- > include/linux/bitmap.h | 35

[PATCH 01/19] bitmap: genericize percpu bitmap region iterators

2019-10-07 Thread Dennis Zhou
Bitmaps are fairly popular for their space efficiency, but we don't have generic iterators available. Make percpu's bitmap region iterators available to everyone. Signed-off-by: Dennis Zhou --- include/linux/bitmap.h | 35 mm/percpu.c| 61 +++-