[PATCH 03/25] vfs: check file ranges before cloning files

2018-10-12 Thread Darrick J. Wong
From: Darrick J. Wong Move the file range checks from vfs_clone_file_prep into a separate generic_remap_checks function so that all the checks are collected in a central location. This forms the basis for adding more checks from generic_write_checks that will make cloning's input checking more c

Re: [PATCH 03/25] vfs: check file ranges before cloning files

2018-10-11 Thread Amir Goldstein
On Thu, Oct 11, 2018 at 4:43 PM Christoph Hellwig wrote: > > > -EXPORT_SYMBOL(vfs_clone_file_prep_inodes); > > +EXPORT_SYMBOL(vfs_clone_file_prep); > > Btw, why isn't this EXPORT_SYMBOL_GPL? It is rather Linux internal > code, including some that I wrote which you lifted into the core > in "vfs:

Re: [PATCH 03/25] vfs: check file ranges before cloning files

2018-10-11 Thread Christoph Hellwig
> -EXPORT_SYMBOL(vfs_clone_file_prep_inodes); > +EXPORT_SYMBOL(vfs_clone_file_prep); Btw, why isn't this EXPORT_SYMBOL_GPL? It is rather Linux internal code, including some that I wrote which you lifted into the core in "vfs: refactor clone/dedupe_file_range common functions".

[PATCH 03/25] vfs: check file ranges before cloning files

2018-10-10 Thread Darrick J. Wong
From: Darrick J. Wong Move the file range checks from vfs_clone_file_prep into a separate generic_remap_checks function so that all the checks are collected in a central location. This forms the basis for adding more checks from generic_write_checks that will make cloning's input checking more c