Re: [PATCH 05/11] btrfs: dev-replace: avoid useless lock on error handling path

2018-09-14 Thread David Sterba
On Fri, Sep 07, 2018 at 04:55:11PM +0200, David Sterba wrote: > The exit sequence in btrfs_dev_replace_start does not allow to simply > add a label to the right place so the error handling after starting > transaction failure jumps there. Currently there's a lock that pairs > with the unlock in the

Re: [PATCH 05/11] btrfs: dev-replace: avoid useless lock on error handling path

2018-09-07 Thread Omar Sandoval
On Fri, Sep 07, 2018 at 04:55:11PM +0200, David Sterba wrote: > The exit sequence in btrfs_dev_replace_start does not allow to simply > add a label to the right place so the error handling after starting > transaction failure jumps there. Currently there's a lock that pairs > with the unlock in the

[PATCH 05/11] btrfs: dev-replace: avoid useless lock on error handling path

2018-09-07 Thread David Sterba
The exit sequence in btrfs_dev_replace_start does not allow to simply add a label to the right place so the error handling after starting transaction failure jumps there. Currently there's a lock that pairs with the unlock in the section, which is unnecessary and only raises questions. Add a varia