Re: [PATCH 07/19] btrfs: discard one region at a time in async discard

On Thu, Oct 10, 2019 at 11:22:44AM -0400, Josef Bacik wrote: > On Mon, Oct 07, 2019 at 04:17:38PM -0400, Dennis Zhou wrote: > > The prior two patches added discarding via a background workqueue. This > > just piggybacked off of the fstrim code to trim the whole block at once. > > Well inevitably th

Re: [PATCH 07/19] btrfs: discard one region at a time in async discard

On Mon, Oct 07, 2019 at 04:17:38PM -0400, Dennis Zhou wrote: > The prior two patches added discarding via a background workqueue. This > just piggybacked off of the fstrim code to trim the whole block at once. > Well inevitably this is worse performance wise and will aggressively > overtrim. But it

[PATCH 07/19] btrfs: discard one region at a time in async discard

The prior two patches added discarding via a background workqueue. This just piggybacked off of the fstrim code to trim the whole block at once. Well inevitably this is worse performance wise and will aggressively overtrim. But it was nice to plumb the other infrastructure to keep the patches easie