Re: [PATCH 09/13] btrfs: make use of btrfs_find_device_by_user_input()

2016-02-15 Thread David Sterba
On Mon, Feb 15, 2016 at 05:47:46PM +0100, David Sterba wrote: > > + struct btrfs_super_block *disk_super = NULL; > > disk_super is NULL here and unchanged until ... > > > + if (!disk_super) { > > ... here, so this will always take this branch > > > + ret =

Re: [PATCH 09/13] btrfs: make use of btrfs_find_device_by_user_input()

2016-02-15 Thread David Sterba
On Sat, Feb 13, 2016 at 10:01:36AM +0800, Anand Jain wrote: > btrfs_rm_device() has a section of the code which can be replaced > btrfs_find_device_by_user_input() > > Signed-off-by: Anand Jain > --- > fs/btrfs/volumes.c | 100 >

[PATCH 09/13] btrfs: make use of btrfs_find_device_by_user_input()

2016-02-12 Thread Anand Jain
btrfs_rm_device() has a section of the code which can be replaced btrfs_find_device_by_user_input() Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 100 - 1 file changed, 37 insertions(+), 63 deletions(-) diff --git