Re: [PATCH 1/2] Btrfs: allocate extent state and check the result properly

2011-04-20 Thread Xiao Guangrong
On 04/19/2011 07:55 PM, Chris Mason wrote: Sorry, could you please change this to check the results of the atomic allocatoin in set/clear_extent_bit? I'd rather not add a new BUG_ON deeper into the code. OK, i have posted the v2 patch to fix it, thanks for your review! -- To unsubscribe

Re: [PATCH 1/2] Btrfs: allocate extent state and check the result properly

2011-04-19 Thread Chris Mason
Excerpts from Xiao Guangrong's message of 2011-04-18 21:49:52 -0400: On 04/12/2011 04:14 PM, Xiao Guangrong wrote: It doesn't allocate extent_state and check the result properly: - in set_extent_bit, it doesn't allocate extent_state if the path is not allowed wait - in

Re: [PATCH 1/2] Btrfs: allocate extent state and check the result properly

2011-04-18 Thread Xiao Guangrong
On 04/12/2011 04:14 PM, Xiao Guangrong wrote: It doesn't allocate extent_state and check the result properly: - in set_extent_bit, it doesn't allocate extent_state if the path is not allowed wait - in clear_extent_bit, it doesn't check the result after atomic-ly allocate, we trigger

[PATCH 1/2] Btrfs: allocate extent state and check the result properly

2011-04-12 Thread Xiao Guangrong
It doesn't allocate extent_state and check the result properly: - in set_extent_bit, it doesn't allocate extent_state if the path is not allowed wait - in clear_extent_bit, it doesn't check the result after atomic-ly allocate, we trigger BUG_ON() if it's fail - if allocate fail, we trigger