Re: [PATCH 1/2] btrfs: clear ordered flag on cleaning up ordered extents

2017-09-08 Thread David Sterba
On Fri, Sep 08, 2017 at 05:10:04PM +0900, Naohiro Aota wrote: > On 2017年09月08日 03:25, David Sterba wrote: > > On Fri, Sep 01, 2017 at 06:59:49PM +0800, Qu Wenruo wrote: > >> On 2017年09月01日 16:58, Naohiro Aota wrote: > >>> commit 524272607e88 ("btrfs: Handle delalloc error correctly to avoid > >>>

Re: [PATCH 1/2] btrfs: clear ordered flag on cleaning up ordered extents

2017-09-08 Thread Naohiro Aota
On 2017年09月08日 03:25, David Sterba wrote: > On Fri, Sep 01, 2017 at 06:59:49PM +0800, Qu Wenruo wrote: >> On 2017年09月01日 16:58, Naohiro Aota wrote: >>> commit 524272607e88 ("btrfs: Handle delalloc error correctly to avoid >>> ordered extent hang") introduced btrfs_cleanup_ordered_extents() to

Re: [PATCH 1/2] btrfs: clear ordered flag on cleaning up ordered extents

2017-09-07 Thread David Sterba
On Fri, Sep 01, 2017 at 06:59:49PM +0800, Qu Wenruo wrote: > On 2017年09月01日 16:58, Naohiro Aota wrote: > > commit 524272607e88 ("btrfs: Handle delalloc error correctly to avoid > > ordered extent hang") introduced btrfs_cleanup_ordered_extents() to cleanup > > submitted ordered extents. However,

Re: [PATCH 1/2] btrfs: clear ordered flag on cleaning up ordered extents

2017-09-01 Thread Josef Bacik
On Fri, Sep 01, 2017 at 05:58:47PM +0900, Naohiro Aota wrote: > commit 524272607e88 ("btrfs: Handle delalloc error correctly to avoid > ordered extent hang") introduced btrfs_cleanup_ordered_extents() to cleanup > submitted ordered extents. However, it does not clear the ordered bit > (Private2)

Re: [PATCH 1/2] btrfs: clear ordered flag on cleaning up ordered extents

2017-09-01 Thread Qu Wenruo
On 2017年09月01日 16:58, Naohiro Aota wrote: commit 524272607e88 ("btrfs: Handle delalloc error correctly to avoid ordered extent hang") introduced btrfs_cleanup_ordered_extents() to cleanup submitted ordered extents. However, it does not clear the ordered bit (Private2) of coresponding pages.

[PATCH 1/2] btrfs: clear ordered flag on cleaning up ordered extents

2017-09-01 Thread Naohiro Aota
commit 524272607e88 ("btrfs: Handle delalloc error correctly to avoid ordered extent hang") introduced btrfs_cleanup_ordered_extents() to cleanup submitted ordered extents. However, it does not clear the ordered bit (Private2) of coresponding pages. Thus, the following BUG occurs from