Re: [PATCH 1/3] Btrfs: replace tree->mapping with tree->private_data

2017-05-09 Thread David Sterba
One comment to the callbacks in extent_io_ops: there are 2 instances of the callback structure and 2 groups of callbacks. The callbacks that exist for both instances are in the "mandatory" group and the rest is in the "optional. As you add set_range_writeback and tree_fs_info to both, please move t

Re: [PATCH 1/3] Btrfs: replace tree->mapping with tree->private_data

2017-05-08 Thread Chandan Rajendra
On Friday, May 05, 2017 11:57:13 AM Josef Bacik wrote: > For extent_io tree's we have carried the address_mapping of the inode around > in > the io tree in order to pull the inode back out for calling into various tree > ops hooks. This works fine when everything that has an extent_io_tree has an

[PATCH 1/3] Btrfs: replace tree->mapping with tree->private_data

2017-05-05 Thread Josef Bacik
For extent_io tree's we have carried the address_mapping of the inode around in the io tree in order to pull the inode back out for calling into various tree ops hooks. This works fine when everything that has an extent_io_tree has an inode. But we are going to remove the btree_inode, so we need