Re: [PATCH 1/3] Btrfs-progs: add missing write check for mkfs

2013-07-03 Thread David Sterba
On Wed, Jul 03, 2013 at 06:25:59PM +0100, Filipe David Manana wrote: > > Also, replacing the BUG_ON with something else would be nice of course. > > If you don't mind, I would prefer to do that as a different patch, > since the BUG_ON() use is what is currently done everywhere in this > function a

Re: [PATCH 1/3] Btrfs-progs: add missing write check for mkfs

2013-07-03 Thread Filipe David Manana
On Wed, Jul 3, 2013 at 6:09 PM, David Sterba wrote: > On Sun, Jun 30, 2013 at 12:51:44PM +0100, Filipe David Borba Manana wrote: >> Assert that the write of the device tree root succeeds. >> This verification is currently done for all other tree >> roots, however it was missing for the device tree

Re: [PATCH 1/3] Btrfs-progs: add missing write check for mkfs

2013-07-03 Thread David Sterba
On Sun, Jun 30, 2013 at 12:51:44PM +0100, Filipe David Borba Manana wrote: > Assert that the write of the device tree root succeeds. > This verification is currently done for all other tree > roots, however it was missing for the device tree root. > > Would this tree root write fail, but all other

[PATCH 1/3] Btrfs-progs: add missing write check for mkfs

2013-06-30 Thread Filipe David Borba Manana
Assert that the write of the device tree root succeeds. This verification is currently done for all other tree roots, however it was missing for the device tree root. Would this tree root write fail, but all others succeed, it would lead to a corrupted/incomplete btrfs filesystem. Signed-off-by: