Re: [PATCH 1/3] btrfs: Remove unused variables

2017-07-18 Thread David Sterba
For dead code removal, please document when it was last used and what's the possible cause the code became unused. It's mostly for obvious reasons, but sometimes it can reveal potential problems. On Thu, Jul 13, 2017 at 11:37:41AM +0300, Nikolay Borisov wrote: > Signed-off-by: Nikolay Borisov > -

Re: [PATCH 1/3] btrfs: Remove unused variables

2017-07-13 Thread Qu Wenruo
On 2017年07月13日 16:37, Nikolay Borisov wrote: Signed-off-by: Nikolay Borisov Looks good. Reviewed-by: Qu Wenruo Kernel makefile disabled unused-but-set-variable warning so we can't detect it in normal compile. Thanks, Qu --- fs/btrfs/volumes.c | 9 - 1 file changed, 9 delet

[PATCH 1/3] btrfs: Remove unused variables

2017-07-13 Thread Nikolay Borisov
Signed-off-by: Nikolay Borisov --- fs/btrfs/volumes.c | 9 - 1 file changed, 9 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 6466f53b1e81..9a38cbf233a1 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1873,7 +1873,6 @@ int btrfs_rm_device(struct btrf