Re: [PATCH 1/3] dm: log writes target

2015-04-07 Thread Josef Bacik
On 03/21/2015 05:50 PM, Dave Chinner wrote: On Thu, Mar 19, 2015 at 04:31:08PM -0400, Josef Bacik wrote: This creates a new target that is meant for file system developers to test file system integrity at particular points in the life of a file system. We capture all write requests and the

Re: [dm-devel] [PATCH 1/3] dm: log writes target

2015-04-07 Thread Josef Bacik
On 03/23/2015 02:02 PM, Vivek Goyal wrote: On Thu, Mar 19, 2015 at 04:31:08PM -0400, Josef Bacik wrote: [..] + * We log writes only after they have been flushed, this makes the log describe + * close to the order in which the data hits the actual disk, not its cache. So + * for example the

Re: [PATCH 1/3] dm: log writes target V2

2015-03-24 Thread Mike Snitzer
On Fri, Mar 20 2015 at 10:50am -0400, Josef Bacik jba...@fb.com wrote: This creates a new target that is meant for file system developers to test file system integrity at particular points in the life of a file system. We capture all write requests and the data and log the requests and

Re: [dm-devel] [PATCH 1/3] dm: log writes target

2015-03-23 Thread Vivek Goyal
On Thu, Mar 19, 2015 at 04:31:08PM -0400, Josef Bacik wrote: [..] + * We log writes only after they have been flushed, this makes the log describe + * close to the order in which the data hits the actual disk, not its cache. So + * for example the following sequence (W means write, C

Re: [PATCH 1/3] dm: log writes target

2015-03-21 Thread Dave Chinner
On Thu, Mar 19, 2015 at 04:31:08PM -0400, Josef Bacik wrote: This creates a new target that is meant for file system developers to test file system integrity at particular points in the life of a file system. We capture all write requests and the data and log the requests and the data to a

[PATCH 1/3] dm: log writes target V2

2015-03-20 Thread Josef Bacik
This creates a new target that is meant for file system developers to test file system integrity at particular points in the life of a file system. We capture all write requests and the data and log the requests and the data to a separate device for later replay. There is a userspace utility to

Re: [PATCH 1/3] dm: log writes target V2

2015-03-20 Thread Zach Brown
On Fri, Mar 20, 2015 at 10:50:37AM -0400, Josef Bacik wrote: This creates a new target that is meant for file system developers to test file system integrity at particular points in the life of a file system. We capture all write requests and the data and log the requests and the data to a

Re: [PATCH 1/3] dm: log writes target

2015-03-19 Thread Zach Brown
On Thu, Mar 19, 2015 at 04:31:08PM -0400, Josef Bacik wrote: This creates a new target that is meant for file system developers to test file system integrity at particular points in the life of a file system. Hi Josef, just a quick drive-by review for stuff that jumps out at me.. +

[PATCH 1/3] dm: log writes target

2015-03-19 Thread Josef Bacik
This creates a new target that is meant for file system developers to test file system integrity at particular points in the life of a file system. We capture all write requests and the data and log the requests and the data to a separate device for later replay. There is a userspace utility to