Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-18 Thread Filipe David Manana
On Fri, Apr 18, 2014 at 6:18 PM, David Sterba wrote: > On Tue, Apr 15, 2014 at 08:49:52PM +0100, Filipe David Manana wrote: >> On Tue, Apr 15, 2014 at 8:35 PM, Mark Fasheh wrote: >> > On Tue, Apr 15, 2014 at 07:30:51PM +0100, Filipe David Manana wrote: >> >> On Tue, Apr 15, 2014 at 7:10 PM, Josef

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-18 Thread David Sterba
On Tue, Apr 15, 2014 at 08:49:52PM +0100, Filipe David Manana wrote: > On Tue, Apr 15, 2014 at 8:35 PM, Mark Fasheh wrote: > > On Tue, Apr 15, 2014 at 07:30:51PM +0100, Filipe David Manana wrote: > >> On Tue, Apr 15, 2014 at 7:10 PM, Josef Bacik wrote: > >> > Just make a SUPPORTS_V2 flag that use

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Filipe David Manana
On Tue, Apr 15, 2014 at 8:35 PM, Mark Fasheh wrote: > On Tue, Apr 15, 2014 at 07:30:51PM +0100, Filipe David Manana wrote: >> On Tue, Apr 15, 2014 at 7:10 PM, Josef Bacik wrote: >> > Just make a SUPPORTS_V2 flag that userspace can pass in through the >> > existing flags to make the kernel spit o

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Mark Fasheh
On Tue, Apr 15, 2014 at 07:30:51PM +0100, Filipe David Manana wrote: > On Tue, Apr 15, 2014 at 7:10 PM, Josef Bacik wrote: > > Just make a SUPPORTS_V2 flag that userspace can pass in through the > > existing flags to make the kernel spit out V2 commands. We don't want to > > break old user spac

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Filipe David Manana
On Tue, Apr 15, 2014 at 7:10 PM, Josef Bacik wrote: > Just make a SUPPORTS_V2 flag that userspace can pass in through the existing > flags to make the kernel spit out V2 commands. We don't want to break old > user space, I still have to see distro guys in real life ;). Thanks, So would this f

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Josef Bacik
Just make a SUPPORTS_V2 flag that userspace can pass in through the existing flags to make the kernel spit out V2 commands. We don't want to break old user space, I still have to see distro guys in real life ;). Thanks, Josef Mark Fasheh wrote: On Tue, Apr 15, 2014 at 06:57:17PM +0100, Fil

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Mark Fasheh
On Tue, Apr 15, 2014 at 06:57:17PM +0100, Filipe David Manana wrote: > >> > Are these changes compatible with software using the old stream version? > >> > We > >> > have snapshotting tools that are using send/recieve and it would be bad > >> > to > >> > change the ABI in incompatible ways undern

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Filipe David Manana
On Tue, Apr 15, 2014 at 6:41 PM, Mark Fasheh wrote: > On Tue, Apr 15, 2014 at 06:34:38PM +0100, Filipe David Manana wrote: >> On Tue, Apr 15, 2014 at 6:28 PM, Mark Fasheh wrote: >> > On Tue, Apr 15, 2014 at 05:40:18PM +0100, Filipe David Borba Manana wrote: >> >> This increases the send stream ve

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Mark Fasheh
On Tue, Apr 15, 2014 at 06:34:38PM +0100, Filipe David Manana wrote: > On Tue, Apr 15, 2014 at 6:28 PM, Mark Fasheh wrote: > > On Tue, Apr 15, 2014 at 05:40:18PM +0100, Filipe David Borba Manana wrote: > >> This increases the send stream version from version 1 to version 2, adding > >> 2 new comma

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Filipe David Manana
On Tue, Apr 15, 2014 at 6:28 PM, Mark Fasheh wrote: > On Tue, Apr 15, 2014 at 05:40:18PM +0100, Filipe David Borba Manana wrote: >> This increases the send stream version from version 1 to version 2, adding >> 2 new commands: >> >> 1) total data size - used to tell the receiver how much file data

Re: [PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Mark Fasheh
On Tue, Apr 15, 2014 at 05:40:18PM +0100, Filipe David Borba Manana wrote: > This increases the send stream version from version 1 to version 2, adding > 2 new commands: > > 1) total data size - used to tell the receiver how much file data the stream >will add or update; > > 2) fallocate - us

[PATCH 1/4] Btrfs: send, bump stream version

2014-04-15 Thread Filipe David Borba Manana
This increases the send stream version from version 1 to version 2, adding 2 new commands: 1) total data size - used to tell the receiver how much file data the stream will add or update; 2) fallocate - used to pre-allocate space for files and to punch holes in files. This is preparation work