Re: [PATCH 1/4] locks: new locks_mandatory_area calling convention

2015-12-08 Thread Al Viro
On Tue, Dec 08, 2015 at 03:54:53PM +0100, Christoph Hellwig wrote: > On Tue, Dec 08, 2015 at 04:05:04AM +, Al Viro wrote: > > Where the hell would truncate(2) get struct file, anyway? IOW, the inode > > argument is _not_ pointless; re-added. > > Oh, right. Interestingly is seems like xfstest

Re: [PATCH 1/4] locks: new locks_mandatory_area calling convention

2015-12-08 Thread Christoph Hellwig
On Tue, Dec 08, 2015 at 04:05:04AM +, Al Viro wrote: > Where the hell would truncate(2) get struct file, anyway? IOW, the inode > argument is _not_ pointless; re-added. Oh, right. Interestingly is seems like xfstests has no coverage of this code path at all. -- To unsubscribe from this list:

Re: [PATCH 1/4] locks: new locks_mandatory_area calling convention

2015-12-07 Thread Al Viro
On Thu, Dec 03, 2015 at 12:59:49PM +0100, Christoph Hellwig wrote: > Pass a loff_t end for the last byte instead of the 32-bit count > parameter to allow full file clones even on 32-bit architectures. > While we're at it also drop the pointless inode argument and simplify > the read/write selection

[PATCH 1/4] locks: new locks_mandatory_area calling convention

2015-12-03 Thread Christoph Hellwig
Pass a loff_t end for the last byte instead of the 32-bit count parameter to allow full file clones even on 32-bit architectures. While we're at it also drop the pointless inode argument and simplify the read/write selection. Signed-off-by: Christoph Hellwig Acked-by: J. Bruce Fields --- fs/loc