> On Jun 6, 2019, at 7:10 AM, Vaneet Narang wrote:
>
> Hi Andrew / David,
>
>
>>> > > -ZSTD_parameters params = ZSTD_getParams(level, src_len, 0);
>>> > > +static ZSTD_parameters params;
>>> >
>>> > > +
>>> > > +params = ZSTD_getParams(level, src_len, 0);
>>>
Hi Andrew / David,
>> > > -ZSTD_parameters params = ZSTD_getParams(level, src_len, 0);
>> > > +static ZSTD_parameters params;
>> >
>> > > +
>> > > +params = ZSTD_getParams(level, src_len, 0);
>> >
>> > No thats' broken, the params can't be static as it depends on level
On Wed, 5 Jun 2019 14:32:53 +0200 David Sterba wrote:
> > >
> > > -static ZSTD_parameters zstd_get_btrfs_parameters(unsigned int level,
> > > +static ZSTD_parameters *zstd_get_btrfs_parameters(unsigned int level,
> > >size_t src_len)
> > > {
> > > -
On Wed, Jun 05, 2019 at 01:57:03PM +0200, David Sterba wrote:
> On Tue, Jun 04, 2019 at 03:43:26PM -0700, Andrew Morton wrote:
> > On Mon, 3 Jun 2019 14:32:03 +0530 Maninder Singh
> > wrote:
> >
> > > currently params structure is passed in all functions, which increases
> > > stack usage in al
On Tue, Jun 04, 2019 at 03:43:26PM -0700, Andrew Morton wrote:
> On Mon, 3 Jun 2019 14:32:03 +0530 Maninder Singh
> wrote:
>
> > currently params structure is passed in all functions, which increases
> > stack usage in all the function and lead to stack overflow on target like
> > ARM with kern
On Mon, 3 Jun 2019 14:32:03 +0530 Maninder Singh
wrote:
> currently params structure is passed in all functions, which increases
> stack usage in all the function and lead to stack overflow on target like
> ARM with kernel stack size of 8 KB so better to pass pointer.
>
> Checked for ARM:
>
>
