Re: [PATCH 1/6] Btrfs: remove superfluous free_extent_buffer

2018-05-15 Thread Nikolay Borisov
On 15.05.2018 20:52, Liu Bo wrote: > @tmp must be NULL at this point, free_extent_buffer is not needed at all. You need to explain that this code is executed only if find_extent_buffer didn't return anything, meaning tmp is null, otherwise it's hard to review this change without looking at the c

[PATCH 1/6] Btrfs: remove superfluous free_extent_buffer

2018-05-15 Thread Liu Bo
@tmp must be NULL at this point, free_extent_buffer is not needed at all. Signed-off-by: Liu Bo --- fs/btrfs/ctree.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index b3f6f300e492..9fa3d77c98d4 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -24