Re: [PATCH 1/7] blk-mq: protect completion path with RCU

2018-01-08 Thread Tejun Heo
Hello, Christoph. On Fri, Dec 29, 2017 at 02:04:18AM -0800, Christoph Hellwig wrote: > Why do you need the srcu protection? The completion path can never > sleep. > > If there is a good reason to keep it please add commment, and > make the srcu variant a separate function only used by drivers th

Re: [PATCH 1/7] blk-mq: protect completion path with RCU

2017-12-29 Thread Christoph Hellwig
Why do you need the srcu protection? The completion path can never sleep. If there is a good reason to keep it please add commment, and make the srcu variant a separate function only used by drivers that need it instead of adding the conditional. -- To unsubscribe from this list: send the line "u

[PATCH 1/7] blk-mq: protect completion path with RCU

2017-12-16 Thread Tejun Heo
Currently, blk-mq protects only the issue path with RCU. This patch puts the completion path under the same RCU protection. This will be used to synchronize issue/completion against timeout by later patches, which will also add the comments. Signed-off-by: Tejun Heo --- block/blk-mq.c | 16 +++