Re: [PATCH 1/8] btrfs: bioset allocations will never fail, adapt our helpers

2017-06-07 Thread Anand Jain
Reviewed-by: Anand Jain -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/8] btrfs: bioset allocations will never fail, adapt our helpers

2017-06-06 Thread Anand Jain
#define __GFP_RECLAIM ((__force gfp_t)(___GFP_DIRECT_RECLAIM|___GFP_KSWAPD_RECLAIM)) #define GFP_NOFS(__GFP_RECLAIM | __GFP_IO) Ah. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH 1/8] btrfs: bioset allocations will never fail, adapt our helpers

2017-06-06 Thread David Sterba
On Tue, Jun 06, 2017 at 06:21:17PM +0800, Anand Jain wrote: > On 06/03/17 00:58, David Sterba wrote: > > Christoph pointed out that bio allocations backed by a bioset will never > > fail. > > Looks like this feature comes when __GFP_DIRECT_RECLAIM is > set and we aren't, such as [1]. Any idea

Re: [PATCH 1/8] btrfs: bioset allocations will never fail, adapt our helpers

2017-06-06 Thread Christoph Hellwig
On Tue, Jun 06, 2017 at 06:21:17PM +0800, Anand Jain wrote: > > > On 06/03/17 00:58, David Sterba wrote: >> Christoph pointed out that bio allocations backed by a bioset will never >> fail. > > David, > > Looks like this feature comes when __GFP_DIRECT_RECLAIM is > set and we aren't, such as [1]

Re: [PATCH 1/8] btrfs: bioset allocations will never fail, adapt our helpers

2017-06-06 Thread Anand Jain
On 06/03/17 00:58, David Sterba wrote: Christoph pointed out that bio allocations backed by a bioset will never fail. David, Looks like this feature comes when __GFP_DIRECT_RECLAIM is set and we aren't, such as [1]. Any idea why? Looks like I am missing something ? [1] - static int

Re: [PATCH 1/8] btrfs: bioset allocations will never fail, adapt our helpers

2017-06-02 Thread Christoph Hellwig
On Fri, Jun 02, 2017 at 06:58:30PM +0200, David Sterba wrote: > Christoph pointed out that bio allocations backed by a bioset will never > fail. As we always use a bioset for all bio allocations, we can skip > the error handling. This patch adjusts our low-level helpers, the > cascaded changes to

[PATCH 1/8] btrfs: bioset allocations will never fail, adapt our helpers

2017-06-02 Thread David Sterba
Christoph pointed out that bio allocations backed by a bioset will never fail. As we always use a bioset for all bio allocations, we can skip the error handling. This patch adjusts our low-level helpers, the cascaded changes to all callers will come next. CC: Christoph Hellwig CC: Liu Bo Signe