This adds show sub-command to the btrfs subvol cli
to display detailed inforamtion of the given subvol
or snapshot.
Signed-off-by: Anand Jain
---
btrfs-list.c | 25 +++-
btrfs-list.h | 3 +-
cmds-subvolume.c | 176 ++-
man/btrfs.
This adds show sub-command to the btrfs subvol cli
to display detailed inforamtion of the given subvol
or snapshot.
Signed-off-by: Anand Jain
---
btrfs-list.c | 25 +++-
btrfs-list.h | 3 +-
cmds-subvolume.c | 172 ++-
man/btrfs.
This adds show sub-command to the btrfs subvol cli
to display detailed inforamtion of the given subvol
or snapshot.
Signed-off-by: Anand Jain
---
btrfs-list.c | 25 +++-
btrfs-list.h | 3 +-
cmds-subvolume.c | 172 ++-
man/btrfs.
This adds show sub-command to the btrfs subvol cli
to display detailed inforamtion of the given subvol
or snapshot.
Signed-off-by: Anand Jain
---
btrfs-list.c | 25 +++--
btrfs-list.h | 3 +-
cmds-subvolume.c | 155 +--
man/btrfs
This adds show sub-command to the btrfs subvol cli
to display detailed inforamtion of the given subvol
or snapshot.
Signed-off-by: Anand Jain
---
btrfs-list.c | 25 +++--
btrfs-list.h | 3 +-
cmds-subvolume.c | 155 +--
man/btrfs
On 1/23/13 2:12 AM, Anand Jain wrote:
> This adds show sub-command to the btrfs subvol cli
> to display detailed inforamtion of the given subvol
> or snapshot.
Couple things below.
> Signed-off-by: Anand Jain
> ---
> btrfs-list.c | 25 +++-
> btrfs-list.h | 3 +-
> cmds-subvolume
> > + if (sv_id == 5) {
> > + printf("%s is btrfs root\n", fullpath);
> > + close(fd);
> > + close(mntfd);
> > + free(mnt);
> > + free(fullpath);
> > + return 1;
>
> Just wondering, at this point might a "goto out;" be cleaner error
>
On Thu, Jan 24, 2013 at 12:42:38PM -0700, Zach Brown wrote:
>
> > > + if (sv_id == 5) {
> > > + printf("%s is btrfs root\n", fullpath);
> > > + close(fd);
> > > + close(mntfd);
> > > + free(mnt);
> > > + free(fullpath);
> > > + return 1;
> >
> > Jus
> > Use safe unwinding in one exit path at the end, please. It's less
> > maddening to audit and less likely to fail over time.
>
> Really, goto is your friend ;)
I'm not going to use the word frenemy. I'm just not :).
- z
--
To unsubscribe from this list: send the line "unsubscribe linux-btrf
Eric. All accepted. Thanks for the review.
Anand
On 01/24/2013 01:06 PM, Eric Sandeen wrote:
On 1/23/13 2:12 AM, Anand Jain wrote:
This adds show sub-command to the btrfs subvol cli
to display detailed inforamtion of the given subvol
or snapshot.
Couple things below.
Signed-off-by: Anand
On Fri, 25 Jan 2013 17:30:39 +0800, Anand Jain wrote:
> This adds show sub-command to the btrfs subvol cli
> to display detailed inforamtion of the given subvol
> or snapshot.
>
> Signed-off-by: Anand Jain
> ---
> btrfs-list.c | 25 +++-
> btrfs-list.h | 3 +-
> cmds-subvolume.c |
Stefan,
Thanks for the review.
if (sv_id == BTRFS_FS_TREE_OBJECTID) {
oh yes.
The common way to handle it is:
static int cmd_subvol_show(int argc, char **argv)
{
int mntfd = -1;
int fd = -1;
char *mnt = NULL;
char *fullpath = NULL;
... everywhere,
12 matches
Mail list logo
