Re: [PATCH 13/13] btrfs: optimize check for stale device

2016-03-22 Thread Anand Jain
On 03/22/2016 08:21 PM, David Sterba wrote: On Fri, Feb 19, 2016 at 03:10:16PM +0800, Anand Jain wrote: I see crashes with btrfs/011 on a non-debugging config [ 641.714363] BUG: unable to handle kernel NULL pointer dereference at 0068 [ 641.716057] IP: [] scrub_setup_ctx.isra.1

Re: [PATCH 13/13] btrfs: optimize check for stale device

2016-03-22 Thread David Sterba
On Fri, Feb 19, 2016 at 03:10:16PM +0800, Anand Jain wrote: > > I see crashes with btrfs/011 on a non-debugging config > > > > [ 641.714363] BUG: unable to handle kernel NULL pointer dereference at > > 0068 > > [ 641.716057] IP: [] scrub_setup_ctx.isra.19+0x1f6/0x260 > > [btrfs] > >

Re: [PATCH 13/13] btrfs: optimize check for stale device

2016-03-09 Thread David Sterba
On Wed, Mar 09, 2016 at 05:54:47PM +0800, Anand Jain wrote: > > the dereference happens at offset 0x68 which matches bdev in > > btrfs_device, so this patch is my best guess at the moment. I'm not able > > to reproduce it directly so I need to wait for a rebuild and repeat. > > > As of now, >

Re: [PATCH 13/13] btrfs: optimize check for stale device

2016-03-09 Thread Anand Jain
Dave, I see crashes with btrfs/011 on a non-debugging config [ 641.714363] BUG: unable to handle kernel NULL pointer dereference at 0068 [ 641.716057] IP: [] scrub_setup_ctx.isra.19+0x1f6/0x260 [btrfs] :: [ 641.744599] Call Trace: [ 641.745553] [] btrfs_scrub_dev+0x13d/0x

Re: [PATCH 13/13] btrfs: optimize check for stale device

2016-02-19 Thread Anand Jain
Dave, I see crashes with btrfs/011 on a non-debugging config Could you share your xfstests config file ? especially the devices config part. Thanks, Anand -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH 13/13] btrfs: optimize check for stale device

2016-02-18 Thread Anand Jain
On 02/18/2016 11:13 PM, David Sterba wrote: On Sat, Feb 13, 2016 at 10:01:40AM +0800, Anand Jain wrote: Optimize check for stale device to only be checked when there is device added or changed. If there is no update to the device, there is no need to call btrfs_free_stale_device(). Signed-off-

Re: [PATCH 13/13] btrfs: optimize check for stale device

2016-02-18 Thread David Sterba
On Sat, Feb 13, 2016 at 10:01:40AM +0800, Anand Jain wrote: > Optimize check for stale device to only be checked when there is device > added or changed. If there is no update to the device, there is no need > to call btrfs_free_stale_device(). > > Signed-off-by: Anand Jain http://thread.gmane.o

[PATCH 13/13] btrfs: optimize check for stale device

2016-02-12 Thread Anand Jain
Optimize check for stale device to only be checked when there is device added or changed. If there is no update to the device, there is no need to call btrfs_free_stale_device(). Signed-off-by: Anand Jain --- This is good to go. The there were some stale devices while testing and now I have con