Re: [PATCH 2/2] Btrfs: fix the snapshot that should not exist

2012-07-30 Thread Miao Xie
On fri, 27 Jul 2012 16:52:21 +0900, Hidetoshi Seto wrote: # ll /mnt/1/snap0/1 total 0 [None] # cd /mnt/1/snap0/1/snap0 [Enter a unexisted directory successfully...] I confirmed that mkdir snap0 failed with File exists and that rmdir can remove the directory snap0. So it is a kind of

Re: [PATCH 2/2] Btrfs: fix the snapshot that should not exist

2012-07-30 Thread Miao Xie
On fri, 27 Jul 2012 14:29:57 +0200, David Sterba wrote: On Fri, Jul 27, 2012 at 04:52:21PM +0900, Hidetoshi Seto wrote: (2012/07/26 15:57), Miao Xie wrote: btrfs_abort_transaction(trans, root, ret); goto fail; } @@ -1386,13 +1408,13 @@ int btrfs_commit_transaction(struct

Re: [PATCH 2/2] Btrfs: fix the snapshot that should not exist

2012-07-27 Thread Hidetoshi Seto
(2012/07/26 15:57), Miao Xie wrote: The snapshot should be the image of the fs tree before it was created, so the metadata of the snapshot should not exist in the its tree. But now, we found the directory item and directory name index is in both the snapshot tree and the fs tree. It introduces

Re: [PATCH 2/2] Btrfs: fix the snapshot that should not exist

2012-07-27 Thread David Sterba
On Fri, Jul 27, 2012 at 04:52:21PM +0900, Hidetoshi Seto wrote: (2012/07/26 15:57), Miao Xie wrote: btrfs_abort_transaction(trans, root, ret); goto fail; } @@ -1386,13 +1408,13 @@ int btrfs_commit_transaction(struct btrfs_trans_handle *trans, */

[PATCH 2/2] Btrfs: fix the snapshot that should not exist

2012-07-26 Thread Miao Xie
The snapshot should be the image of the fs tree before it was created, so the metadata of the snapshot should not exist in the its tree. But now, we found the directory item and directory name index is in both the snapshot tree and the fs tree. It introduces some problem and makes the users feel