Re: [PATCH 2/2] Btrfs: fix wrong the mount information in /proc

2012-05-31 Thread Josef Bacik
On Thu, May 31, 2012 at 04:53:04PM +0100, Al Viro wrote: > On Thu, May 31, 2012 at 03:36:05PM +0100, Al Viro wrote: > > On Thu, May 31, 2012 at 06:25:14PM +0800, Miao Xie wrote: > > > +#include "../mount.h" > > > > No. > > > > > + struct mount *r = real_mount(mnt); > > > > And even more so. Fin

Re: [PATCH 2/2] Btrfs: fix wrong the mount information in /proc

2012-05-31 Thread Al Viro
On Thu, May 31, 2012 at 03:36:05PM +0100, Al Viro wrote: > On Thu, May 31, 2012 at 06:25:14PM +0800, Miao Xie wrote: > > +#include "../mount.h" > > No. > > > + struct mount *r = real_mount(mnt); > > And even more so. Find a way to do that without layering violations or > live with the current

Re: [PATCH 2/2] Btrfs: fix wrong the mount information in /proc

2012-05-31 Thread Al Viro
On Thu, May 31, 2012 at 06:25:14PM +0800, Miao Xie wrote: > +#include "../mount.h" No. > + struct mount *r = real_mount(mnt); And even more so. Find a way to do that without layering violations or live with the current behaviour. Both patches NAKed with extreme prejudice. Don't bring them

[PATCH 2/2] Btrfs: fix wrong the mount information in /proc

2012-05-31 Thread Miao Xie
If we remove the disk that is specified when mounting, the mount information in /proc can not be updated. It will make us can not add that disk back into the filesystem. This patch fix this problem by implement the show_devname() interface and choose the name of the device with minimum device id to