Re: [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option

2012-11-01 Thread Liu Bo
On 11/01/2012 10:43 PM, Chris Mason wrote: > On Sat, Oct 27, 2012 at 04:28:41AM -0600, Liu Bo wrote: >> This feature works on our crucial write endio path, so if we've got >> lots of fragments to process, it will be kind of a disaster to the >> performance, so I make such a change. >> >> One can be

Re: [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option

2012-11-01 Thread Chris Mason
On Sat, Oct 27, 2012 at 04:28:41AM -0600, Liu Bo wrote: > This feature works on our crucial write endio path, so if we've got > lots of fragments to process, it will be kind of a disaster to the > performance, so I make such a change. > > One can benifit from it while mounting with '-o snap_aware_

Re: [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option

2012-10-31 Thread Liu Bo
On 10/31/2012 08:44 AM, David Sterba wrote: > On Wed, Oct 31, 2012 at 08:34:38AM +0800, Liu Bo wrote: >> Besides 'btrfs fi defrag', mounting with autodefrag may also do the same >> thing. > > Ok, autodefrag, good point. Then I suggest to make the snapshot-aware a > mode of autodefrag, not a separ

Re: [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option

2012-10-30 Thread David Sterba
On Wed, Oct 31, 2012 at 08:34:38AM +0800, Liu Bo wrote: > Besides 'btrfs fi defrag', mounting with autodefrag may also do the same > thing. Ok, autodefrag, good point. Then I suggest to make the snapshot-aware a mode of autodefrag, not a separate option (because it would make no sense other than

Re: [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option

2012-10-30 Thread Liu Bo
On 10/31/2012 07:31 AM, David Sterba wrote: > On Sat, Oct 27, 2012 at 06:28:41PM +0800, Liu Bo wrote: >> This feature works on our crucial write endio path, so if we've got >> lots of fragments to process, it will be kind of a disaster to the >> performance, so I make such a change. >> >> One can b

Re: [PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option

2012-10-30 Thread David Sterba
On Sat, Oct 27, 2012 at 06:28:41PM +0800, Liu Bo wrote: > This feature works on our crucial write endio path, so if we've got > lots of fragments to process, it will be kind of a disaster to the > performance, so I make such a change. > > One can benifit from it while mounting with '-o snap_aware_

[PATCH 2/2] Btrfs: make snapshot-aware defrag as a mount option

2012-10-27 Thread Liu Bo
This feature works on our crucial write endio path, so if we've got lots of fragments to process, it will be kind of a disaster to the performance, so I make such a change. One can benifit from it while mounting with '-o snap_aware_defrag'. Signed-off-by: Liu Bo --- fs/btrfs/ctree.h |1 + f