Re: [PATCH 2/2] btrfs: always wait on ordered extents at fsync time

2018-05-23 Thread Filipe Manana
On Tue, May 22, 2018 at 6:47 PM, Josef Bacik wrote: > From: Josef Bacik > > There's a priority inversion that exists currently with btrfs fsync. In > some cases we will collect outstanding ordered extents onto a list and > only wait on them at the very last second. However this "very last > sec

Re: [PATCH 2/2] btrfs: always wait on ordered extents at fsync time

2018-05-23 Thread Nikolay Borisov
On 23.05.2018 18:38, Josef Bacik wrote: > It's just removing all of the code that is no longer needed with the > unconditional wait_ordered_extents, it's not that complicated. Just because something is painfully obvious to you doesn't mean it's the same for others. Especially given the current c

Re: [PATCH 2/2] btrfs: always wait on ordered extents at fsync time

2018-05-23 Thread Josef Bacik
It's just removing all of the code that is no longer needed with the unconditional wait_ordered_extents, it's not that complicated. Thanks, Josef On Wed, May 23, 2018 at 8:24 AM, David Sterba wrote: > On Tue, May 22, 2018 at 01:47:23PM -0400, Josef Bacik wrote: >> From: Josef Bacik >> >> There'

Re: [PATCH 2/2] btrfs: always wait on ordered extents at fsync time

2018-05-23 Thread David Sterba
On Tue, May 22, 2018 at 01:47:23PM -0400, Josef Bacik wrote: > From: Josef Bacik > > There's a priority inversion that exists currently with btrfs fsync. In > some cases we will collect outstanding ordered extents onto a list and > only wait on them at the very last second. However this "very l

[PATCH 2/2] btrfs: always wait on ordered extents at fsync time

2018-05-22 Thread Josef Bacik
From: Josef Bacik There's a priority inversion that exists currently with btrfs fsync. In some cases we will collect outstanding ordered extents onto a list and only wait on them at the very last second. However this "very last second" falls inside of a transaction handle, so if we are in a low