Re: [PATCH 2/2] btrfs: clean up transaction abort messages

2013-03-11 Thread David Sterba
On Mon, Mar 11, 2013 at 12:02:09PM -0700, Zach Brown wrote: > No worries if you're not keen to fix it up, but it'd be nice. One less > wart to be distracted by when stumbling through the code. I'll gladly update the code, thanks for the hints and comments. david -- To unsubscribe from this list:

Re: [PATCH 2/2] btrfs: clean up transaction abort messages

2013-03-11 Thread Zach Brown
> * print the exact negative errno from btrfs_decode_error and > don't expect a simple snprintf to fail What an.. odd function. Looks like it was inherited from ext*. And the callers over in that neck of the woods also don't check for the implemented-but-basically-impossible snprintf failure t

[PATCH 2/2] btrfs: clean up transaction abort messages

2013-03-11 Thread David Sterba
The transaction abort stacktrace is printed only once per module lifetime, but we'd like to see it each time it happens per filesystem. Introduce a fs_state flag that records the state. Tweak the messages around abort: * add error number to the first abor * print the exact negative errno from btrf