Re: [PATCH 2/2] btrfs-progs: Deprecate unused super block member log_root_transid

2018-10-25 Thread Nikolay Borisov
On 25.10.2018 14:18, David Sterba wrote: > On Wed, Oct 24, 2018 at 03:48:07PM +0100, Nikolay Borisov wrote: >> >> >> On 24.10.18 г. 15:30 ч., David Sterba wrote: >>> On Fri, Oct 12, 2018 at 05:57:29PM +0800, Qu Wenruo wrote: + printf("log_root_transid (deprecated)\t%llu\n", >>>

Re: [PATCH 2/2] btrfs-progs: Deprecate unused super block member log_root_transid

2018-10-25 Thread David Sterba
On Wed, Oct 24, 2018 at 03:48:07PM +0100, Nikolay Borisov wrote: > > > On 24.10.18 г. 15:30 ч., David Sterba wrote: > > On Fri, Oct 12, 2018 at 05:57:29PM +0800, Qu Wenruo wrote: > >> + printf("log_root_transid (deprecated)\t%llu\n", > >> + le64_to_cpu(sb->__unused_log_ro

Re: [PATCH 2/2] btrfs-progs: Deprecate unused super block member log_root_transid

2018-10-24 Thread Nikolay Borisov
On 24.10.18 г. 15:30 ч., David Sterba wrote: > On Fri, Oct 12, 2018 at 05:57:29PM +0800, Qu Wenruo wrote: >> +printf("log_root_transid (deprecated)\t%llu\n", >> + le64_to_cpu(sb->__unused_log_root_transid)); > > This should be entirely removed. It

Re: [PATCH 2/2] btrfs-progs: Deprecate unused super block member log_root_transid

2018-10-24 Thread David Sterba
On Fri, Oct 12, 2018 at 05:57:29PM +0800, Qu Wenruo wrote: > +printf("log_root_transid (deprecated)\t%llu\n", > + le64_to_cpu(sb->__unused_log_root_transid)); > >>> > >>> This should be entirely removed. > >> > >> It looks OK to me. > >> Just like the old leafsize. >

Re: [PATCH 2/2] btrfs-progs: Deprecate unused super block member log_root_transid

2018-10-12 Thread Qu Wenruo
On 2018/10/12 下午5:13, Nikolay Borisov wrote: > > > On 12.10.2018 11:46, Qu Wenruo wrote: >> >> >> On 2018/10/12 下午2:53, Nikolay Borisov wrote: >>> >>> >>> On 12.10.2018 09:42, Qu Wenruo wrote: The only user of it is "btrfs inspect dump-super". Signed-off-by: Qu Wenruo ---

Re: [PATCH 2/2] btrfs-progs: Deprecate unused super block member log_root_transid

2018-10-12 Thread Nikolay Borisov
On 12.10.2018 11:46, Qu Wenruo wrote: > > > On 2018/10/12 下午2:53, Nikolay Borisov wrote: >> >> >> On 12.10.2018 09:42, Qu Wenruo wrote: >>> The only user of it is "btrfs inspect dump-super". >>> >>> Signed-off-by: Qu Wenruo >>> --- >>> cmds-inspect-dump-super.c | 4 ++-- >>> ctree.h

Re: [PATCH 2/2] btrfs-progs: Deprecate unused super block member log_root_transid

2018-10-12 Thread Qu Wenruo
On 2018/10/12 下午2:53, Nikolay Borisov wrote: > > > On 12.10.2018 09:42, Qu Wenruo wrote: >> The only user of it is "btrfs inspect dump-super". >> >> Signed-off-by: Qu Wenruo >> --- >> cmds-inspect-dump-super.c | 4 ++-- >> ctree.h | 6 ++ >> 2 files changed, 4 insertion

Re: [PATCH 2/2] btrfs-progs: Deprecate unused super block member log_root_transid

2018-10-11 Thread Nikolay Borisov
On 12.10.2018 09:42, Qu Wenruo wrote: > The only user of it is "btrfs inspect dump-super". > > Signed-off-by: Qu Wenruo > --- > cmds-inspect-dump-super.c | 4 ++-- > ctree.h | 6 ++ > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/cmds-inspect-dump-su

[PATCH 2/2] btrfs-progs: Deprecate unused super block member log_root_transid

2018-10-11 Thread Qu Wenruo
The only user of it is "btrfs inspect dump-super". Signed-off-by: Qu Wenruo --- cmds-inspect-dump-super.c | 4 ++-- ctree.h | 6 ++ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/cmds-inspect-dump-super.c b/cmds-inspect-dump-super.c index e965267c5d96..3f339