Re: [PATCH 2/3] btrfs: extended inode refs

2012-08-15 Thread Mark Fasheh
On Wed, Aug 15, 2012 at 05:04:48PM +0200, Jan Schmidt wrote: > When applying this patch I get: > > warning: 2 lines add whitespace errors. > Oop, I'll fix that up. > More comments inline. > > On Wed, August 08, 2012 at 20:55 (+0200), Mark Fasheh wrote: > > Teach tree-log.c about extended inod

Re: [PATCH 2/3] btrfs: extended inode refs

2012-08-15 Thread Jan Schmidt
When applying this patch I get: warning: 2 lines add whitespace errors. More comments inline. On Wed, August 08, 2012 at 20:55 (+0200), Mark Fasheh wrote: > Teach tree-log.c about extended inode refs. In particular, we have to adjust > the behavior of inode ref replay as well as log tree recover

[PATCH 2/3] btrfs: extended inode refs

2012-08-08 Thread Mark Fasheh
Teach tree-log.c about extended inode refs. In particular, we have to adjust the behavior of inode ref replay as well as log tree recovery to account for the existence of extended refs. Signed-off-by: Mark Fasheh --- fs/btrfs/backref.c | 68 fs/btrfs/backref.h |5 + fs/btrfs

Re: [PATCH 2/3] btrfs: extended inode refs

2012-08-06 Thread Mark Fasheh
On Fri, Jul 06, 2012 at 04:57:15PM +0200, Jan Schmidt wrote: > Thought about this search_done once again, I'd like to repeat our May's > conversation: > > On Fri, May 04, 2012 at 01:12 (+0200), Mark Fasheh wrote: > > > You moved this comment and assignment out of the "if (ret == 0)" case. > > > I'

Re: [PATCH 2/3] btrfs: extended inode refs

2012-07-06 Thread Jan Schmidt
On Mon, May 21, 2012 at 23:46 (+0200), Mark Fasheh wrote: > From: Mark Fasheh > > Teach tree-log.c about extended inode refs. In particular, we have to adjust > the behavior of inode ref replay as well as log tree recovery to account for > the existence of extended refs. > > Signed-off-by: Mark

[PATCH 2/3] btrfs: extended inode refs

2012-05-21 Thread Mark Fasheh
From: Mark Fasheh Teach tree-log.c about extended inode refs. In particular, we have to adjust the behavior of inode ref replay as well as log tree recovery to account for the existence of extended refs. Signed-off-by: Mark Fasheh --- fs/btrfs/backref.c | 68 +++ fs/btrfs/backref.h

Re: [PATCH 2/3] btrfs: extended inode refs

2012-05-04 Thread David Sterba
On Thu, May 03, 2012 at 04:12:21PM -0700, Mark Fasheh wrote: > > > + > > > + ref_ptr = btrfs_item_ptr_offset(eb, slot); > > > + > > > + /* So that we don't loop back looking for old style log refs. */ > > > + ref_end = ref_ptr; > > > + > > > + extref = (struct btrfs_

Re: [PATCH 2/3] btrfs: extended inode refs

2012-05-03 Thread Mark Fasheh
On Thu, Apr 12, 2012 at 03:08:35PM +0200, Jan Schmidt wrote: > On 05.04.2012 22:09, Mark Fasheh wrote: > > Teach tree-log.c about extended inode refs. In particular, we have to adjust > > the behavior of inode ref replay as well as log tree recovery to account for > > the existence of extended refs

Re: [PATCH 2/3] btrfs: extended inode refs

2012-05-01 Thread Mark Fasheh
On Thu, Apr 12, 2012 at 05:53:15PM +0200, Jan Schmidt wrote: > Hi Mark, > > While reading 3/3 I stumbled across one more thing in this one: > > On 05.04.2012 22:09, Mark Fasheh wrote: > > +int btrfs_find_one_extref(struct btrfs_root *root, u64 inode_objectid, > > + u64 start_o

Re: [PATCH 2/3] btrfs: extended inode refs

2012-04-12 Thread Jan Schmidt
Hi Mark, While reading 3/3 I stumbled across one more thing in this one: On 05.04.2012 22:09, Mark Fasheh wrote: > +int btrfs_find_one_extref(struct btrfs_root *root, u64 inode_objectid, > + u64 start_off, struct btrfs_path *path, > + struct btrfs_inode

Re: [PATCH 2/3] btrfs: extended inode refs

2012-04-12 Thread Jan Schmidt
On 05.04.2012 22:09, Mark Fasheh wrote: > Teach tree-log.c about extended inode refs. In particular, we have to adjust > the behavior of inode ref replay as well as log tree recovery to account for > the existence of extended refs. > > Signed-off-by: Mark Fasheh > --- > fs/btrfs/tree-log.c | 32

[PATCH 2/3] btrfs: extended inode refs

2012-04-05 Thread Mark Fasheh
Teach tree-log.c about extended inode refs. In particular, we have to adjust the behavior of inode ref replay as well as log tree recovery to account for the existence of extended refs. Signed-off-by: Mark Fasheh --- fs/btrfs/tree-log.c | 320 +-