Re: [PATCH 2/3] writeback: allow for dirty metadata accounting

2016-09-12 Thread Dave Chinner
On Mon, Sep 12, 2016 at 10:56:04AM -0400, Josef Bacik wrote: > I think that looping through all the sb's in the system would be > kinda shitty for this tho, we want the "get number of dirty pages" > part to be relatively fast. What if I do something like the > shrinker_control only for dirty

Re: [PATCH 2/3] writeback: allow for dirty metadata accounting

2016-09-12 Thread Dave Chinner
On Mon, Sep 12, 2016 at 10:24:12AM -0400, Josef Bacik wrote: > Dave your reply got eaten somewhere along the way for me, so all i > have is this email. I'm going to respond to your stuff here. No worries, I'll do a 2-in-1 reply :P > On 09/12/2016 03:34 AM, Jan Kara wrote: > >On Mon 12-09-16

Re: [PATCH 2/3] writeback: allow for dirty metadata accounting

2016-09-12 Thread Josef Bacik
On 09/09/2016 04:17 AM, Jan Kara wrote: On Mon 22-08-16 13:35:01, Josef Bacik wrote: Provide a mechanism for file systems to indicate how much dirty metadata they are holding. This introduces a few things 1) Zone stats for dirty metadata, which is the same as the NR_FILE_DIRTY. 2) WB stat for

Re: [PATCH 2/3] writeback: allow for dirty metadata accounting

2016-09-12 Thread Josef Bacik
Dave your reply got eaten somewhere along the way for me, so all i have is this email. I'm going to respond to your stuff here. On 09/12/2016 03:34 AM, Jan Kara wrote: On Mon 12-09-16 10:46:56, Dave Chinner wrote: On Fri, Sep 09, 2016 at 10:17:43AM +0200, Jan Kara wrote: On Mon 22-08-16

Re: [PATCH 2/3] writeback: allow for dirty metadata accounting

2016-09-12 Thread Jan Kara
On Mon 12-09-16 10:46:56, Dave Chinner wrote: > On Fri, Sep 09, 2016 at 10:17:43AM +0200, Jan Kara wrote: > > On Mon 22-08-16 13:35:01, Josef Bacik wrote: > > > Provide a mechanism for file systems to indicate how much dirty metadata > > > they > > > are holding. This introduces a few things > >

Re: [PATCH 2/3] writeback: allow for dirty metadata accounting

2016-09-11 Thread Dave Chinner
On Fri, Sep 09, 2016 at 10:17:43AM +0200, Jan Kara wrote: > On Mon 22-08-16 13:35:01, Josef Bacik wrote: > > Provide a mechanism for file systems to indicate how much dirty metadata > > they > > are holding. This introduces a few things > > > > 1) Zone stats for dirty metadata, which is the

Re: [PATCH 2/3] writeback: allow for dirty metadata accounting

2016-09-09 Thread Jan Kara
On Mon 22-08-16 13:35:01, Josef Bacik wrote: > Provide a mechanism for file systems to indicate how much dirty metadata they > are holding. This introduces a few things > > 1) Zone stats for dirty metadata, which is the same as the NR_FILE_DIRTY. > 2) WB stat for dirty metadata. This way we

[PATCH 2/3] writeback: allow for dirty metadata accounting

2016-08-22 Thread Josef Bacik
Provide a mechanism for file systems to indicate how much dirty metadata they are holding. This introduces a few things 1) Zone stats for dirty metadata, which is the same as the NR_FILE_DIRTY. 2) WB stat for dirty metadata. This way we know if we need to try and call into the file system to