[PATCH 2/3 RFC] btrfs: total_devices should count replacing devices

2014-03-07 Thread Anand Jain
ioctl(BTRFS_IOC_FS_INFO) returns num_devices which does not count seed device. num_devices is used to calculate the number of slots during the ioctl(BTRFS_IOC_DEV_INFO) but ioctl(BTRFS_IOC_DEV_INFO) would count seed devices as well. Due to this miss match btrfs_progs get_fs_info() hits the bug..

Re: [PATCH 2/3 RFC] btrfs: total_devices should count replacing devices

2014-05-13 Thread Wang Shilong
Hello Anand, I agree we can export @total_devices to fix 'btrfs file show' problem. This patch addressed two problem, it is better to split it into two patches. Could you please resend the patch, at least we should fix 'btrfs file show' problem firstly. Thanks, Wang On 03/07/2014 11:48 PM, Ana

Re: [PATCH 2/3 RFC] btrfs: total_devices should count replacing devices

2014-05-14 Thread Anand Jain
Hello Wang, sure will do. Thanks for the comments. Anand On 13/05/14 17:17, Wang Shilong wrote: Hello Anand, I agree we can export @total_devices to fix 'btrfs file show' problem. This patch addressed two problem, it is better to split it into two patches. Could you please resend the patch

Re: [PATCH 2/3 RFC] btrfs: total_devices should count replacing devices

2014-05-16 Thread Anand Jain
Wang, After a much of investigation on this, I think I found a better approach to fix this. Can you kindly comment on patch [PATCH] btrfs: ioctl BTRFS_IOC_FS_INFO and BTRFS_IOC_DEV_INFO miss-matched with slots Thanks, Anand On 14/05/14 16:30, Anand Jain wrote: Hello Wang, sure will