Re: [PATCH 2/5] Btrfs: fix inode cache block reserve leak on failure to allocate data space

2019-07-07 Thread Nikolay Borisov
On 5.07.19 г. 17:32 ч., Filipe Manana wrote: > Nikolay, > > The bytes_may_use counter gets decremented once the extent is allocated. > If we were leaking it, we would see a trace when unmounting the > filesystem, and I certainly wouldn't send this patch trading a few > warnings for another one

Re: [PATCH 2/5] Btrfs: fix inode cache block reserve leak on failure to allocate data space

2019-07-05 Thread Filipe Manana
On Fri, Jul 5, 2019 at 3:26 PM Nikolay Borisov wrote: > > > > On 5.07.19 г. 17:23 ч., Filipe Manana wrote: > > On Fri, Jul 5, 2019 at 3:09 PM Nikolay Borisov wrote: > >> > >> > >> > >> On 5.07.19 г. 13:42 ч., Filipe Manana wrote: > >>> On Fri, Jul 5, 2019 at 11:01 AM Nikolay Borisov wrote: > >>>

Re: [PATCH 2/5] Btrfs: fix inode cache block reserve leak on failure to allocate data space

2019-07-05 Thread Nikolay Borisov
On 5.07.19 г. 17:23 ч., Filipe Manana wrote: > On Fri, Jul 5, 2019 at 3:09 PM Nikolay Borisov wrote: >> >> >> >> On 5.07.19 г. 13:42 ч., Filipe Manana wrote: >>> On Fri, Jul 5, 2019 at 11:01 AM Nikolay Borisov wrote: On 4.07.19 г. 18:24 ч., fdman...@kernel.org wrote: >

Re: [PATCH 2/5] Btrfs: fix inode cache block reserve leak on failure to allocate data space

2019-07-05 Thread Filipe Manana
On Fri, Jul 5, 2019 at 3:09 PM Nikolay Borisov wrote: > > > > On 5.07.19 г. 13:42 ч., Filipe Manana wrote: > > On Fri, Jul 5, 2019 at 11:01 AM Nikolay Borisov wrote: > >> > >> > >> > >> On 4.07.19 г. 18:24 ч., fdman...@kernel.org wrote: > >>> From: Filipe Manana > >>> > >>> If we failed to alloc

Re: [PATCH 2/5] Btrfs: fix inode cache block reserve leak on failure to allocate data space

2019-07-05 Thread Nikolay Borisov
On 5.07.19 г. 13:42 ч., Filipe Manana wrote: > On Fri, Jul 5, 2019 at 11:01 AM Nikolay Borisov wrote: >> >> >> >> On 4.07.19 г. 18:24 ч., fdman...@kernel.org wrote: >>> From: Filipe Manana >>> >>> If we failed to allocate the data extent(s) for the inode space cache, we >>> were bailing out wi

Re: [PATCH 2/5] Btrfs: fix inode cache block reserve leak on failure to allocate data space

2019-07-05 Thread Filipe Manana
On Fri, Jul 5, 2019 at 11:01 AM Nikolay Borisov wrote: > > > > On 4.07.19 г. 18:24 ч., fdman...@kernel.org wrote: > > From: Filipe Manana > > > > If we failed to allocate the data extent(s) for the inode space cache, we > > were bailing out without releasing the previously reserved metadata. This

Re: [PATCH 2/5] Btrfs: fix inode cache block reserve leak on failure to allocate data space

2019-07-05 Thread Nikolay Borisov
On 4.07.19 г. 18:24 ч., fdman...@kernel.org wrote: > From: Filipe Manana > > If we failed to allocate the data extent(s) for the inode space cache, we > were bailing out without releasing the previously reserved metadata. This > was triggering the following warnings when unmounting a filesyste

[PATCH 2/5] Btrfs: fix inode cache block reserve leak on failure to allocate data space

2019-07-04 Thread fdmanana
From: Filipe Manana If we failed to allocate the data extent(s) for the inode space cache, we were bailing out without releasing the previously reserved metadata. This was triggering the following warnings when unmounting a filesystem: $ cat -n fs/btrfs/inode.c (...) 9268 void btrfs_destr