Re: [PATCH 2/5] btrfs: Always limit inline extent size by uncompressed size

2018-03-06 Thread Qu Wenruo
On 2018年03月06日 19:58, David Sterba wrote: > On Fri, Mar 02, 2018 at 07:40:14PM +0800, Qu Wenruo wrote: >> On 2018年03月02日 19:00, Filipe Manana wrote: >>> On Fri, Mar 2, 2018 at 10:54 AM, Qu Wenruo wrote: On 2018年03月02日 18:46, Filipe Manana wrote: > On Fri, Mar 2,

Re: [PATCH 2/5] btrfs: Always limit inline extent size by uncompressed size

2018-03-06 Thread David Sterba
On Fri, Mar 02, 2018 at 07:40:14PM +0800, Qu Wenruo wrote: > On 2018年03月02日 19:00, Filipe Manana wrote: > > On Fri, Mar 2, 2018 at 10:54 AM, Qu Wenruo wrote: > >> On 2018年03月02日 18:46, Filipe Manana wrote: > >>> On Fri, Mar 2, 2018 at 5:22 AM, Qu Wenruo

Re: [PATCH 2/5] btrfs: Always limit inline extent size by uncompressed size

2018-03-02 Thread Qu Wenruo
On 2018年03月02日 19:00, Filipe Manana wrote: > On Fri, Mar 2, 2018 at 10:54 AM, Qu Wenruo wrote: >> >> >> On 2018年03月02日 18:46, Filipe Manana wrote: >>> On Fri, Mar 2, 2018 at 5:22 AM, Qu Wenruo wrote: Normally when specifying max_inline, we should

Re: [PATCH 2/5] btrfs: Always limit inline extent size by uncompressed size

2018-03-02 Thread Filipe Manana
On Fri, Mar 2, 2018 at 10:54 AM, Qu Wenruo wrote: > > > On 2018年03月02日 18:46, Filipe Manana wrote: >> On Fri, Mar 2, 2018 at 5:22 AM, Qu Wenruo wrote: >>> Normally when specifying max_inline, we should normally limit it by >>> uncompressed extent size, as

Re: [PATCH 2/5] btrfs: Always limit inline extent size by uncompressed size

2018-03-02 Thread Qu Wenruo
On 2018年03月02日 18:46, Filipe Manana wrote: > On Fri, Mar 2, 2018 at 5:22 AM, Qu Wenruo wrote: >> Normally when specifying max_inline, we should normally limit it by >> uncompressed extent size, as it's the only thing user can control. > > Why does it matter that users can

Re: [PATCH 2/5] btrfs: Always limit inline extent size by uncompressed size

2018-03-02 Thread Filipe Manana
On Fri, Mar 2, 2018 at 5:22 AM, Qu Wenruo wrote: > Normally when specifying max_inline, we should normally limit it by > uncompressed extent size, as it's the only thing user can control. Why does it matter that users can control it? Will they write less (or more) data to files

[PATCH 2/5] btrfs: Always limit inline extent size by uncompressed size

2018-03-01 Thread Qu Wenruo
Normally when specifying max_inline, we should normally limit it by uncompressed extent size, as it's the only thing user can control. (Control the algorithm and compressed data is almost impossible) Since btrfs is providing *TRANSPARENT* compression, max_inline should behave the same for both