Re: [PATCH 2/5] btrfs-progs: btrfs_add_to_fsid: check if adding device would overflow

2019-08-27 Thread David Sterba
On Tue, Aug 13, 2019 at 09:03:59PM -0400, Jeff Mahoney wrote: > It's theoretically possible to add multiple devices with sizes that add up > to or exceed 16EiB. A file system will be created successfully but will > have a superblock with incorrect values for total_bytes and other fields. > > Kern

Re: [PATCH 2/5] btrfs-progs: btrfs_add_to_fsid: check if adding device would overflow

2019-08-13 Thread Qu Wenruo
On 2019/8/14 上午9:03, Jeff Mahoney wrote: > It's theoretically possible to add multiple devices with sizes that add up > to or exceed 16EiB. A file system will be created successfully but will > have a superblock with incorrect values for total_bytes and other fields. > > Kernels up to v5.0 will

[PATCH 2/5] btrfs-progs: btrfs_add_to_fsid: check if adding device would overflow

2019-08-13 Thread Jeff Mahoney
It's theoretically possible to add multiple devices with sizes that add up to or exceed 16EiB. A file system will be created successfully but will have a superblock with incorrect values for total_bytes and other fields. Kernels up to v5.0 will crash when they encounter this scenario. We need to