Re: [PATCH 2/9] dcache: close d_move race in d_splice_alias

2014-02-20 Thread Christoph Hellwig
On Tue, Feb 18, 2014 at 03:28:58PM -0500, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > d_splice_alias will d_move an IS_ROOT() directory dentry into place if > one exists. This should be safe as long as the dentry remains IS_ROOT, > but I can't see what guarantees that: once we drop the

[PATCH 2/9] dcache: close d_move race in d_splice_alias

2014-02-18 Thread J. Bruce Fields
From: "J. Bruce Fields" d_splice_alias will d_move an IS_ROOT() directory dentry into place if one exists. This should be safe as long as the dentry remains IS_ROOT, but I can't see what guarantees that: once we drop the i_lock all we hold here is the i_mutex on an unrelated parent directory. I