Re: [PATCH 3/3] btrfs: fix inline compressed read err corruption

2014-05-14 Thread Chris Mason
On 05/12/2014 01:18 PM, David Sterba wrote: > On Mon, May 12, 2014 at 11:00:23PM +0800, Liu Bo wrote: >> On Thu, May 08, 2014 at 07:16:19PM -0400, Zach Brown wrote: >>> uncompress_inline() is silently dropping an error from >>> btrfs_decompress() after testing it and zeroing the page that was >>> s

Re: [PATCH 3/3] btrfs: fix inline compressed read err corruption

2014-05-12 Thread David Sterba
On Mon, May 12, 2014 at 11:00:23PM +0800, Liu Bo wrote: > On Thu, May 08, 2014 at 07:16:19PM -0400, Zach Brown wrote: > > uncompress_inline() is silently dropping an error from > > btrfs_decompress() after testing it and zeroing the page that was > > supposed to hold decompressed data. This can si

Re: [PATCH 3/3] btrfs: fix inline compressed read err corruption

2014-05-12 Thread Liu Bo
On Thu, May 08, 2014 at 07:16:19PM -0400, Zach Brown wrote: > uncompress_inline() is silently dropping an error from > btrfs_decompress() after testing it and zeroing the page that was > supposed to hold decompressed data. This can silently turn compressed > inline data in to zeros if decompressio

Re: [PATCH 3/3] btrfs: fix inline compressed read err corruption

2014-05-09 Thread Zach Brown
On Fri, May 09, 2014 at 03:58:00PM +0200, David Sterba wrote: > On Thu, May 08, 2014 at 07:16:19PM -0400, Zach Brown wrote: > > uncompress_inline() is silently dropping an error from > > btrfs_decompress() after testing it and zeroing the page that was > > supposed to hold decompressed data. This

Re: [PATCH 3/3] btrfs: fix inline compressed read err corruption

2014-05-09 Thread David Sterba
On Thu, May 08, 2014 at 07:16:19PM -0400, Zach Brown wrote: > uncompress_inline() is silently dropping an error from > btrfs_decompress() after testing it and zeroing the page that was > supposed to hold decompressed data. This can silently turn compressed > inline data in to zeros if decompressio

[PATCH 3/3] btrfs: fix inline compressed read err corruption

2014-05-08 Thread Zach Brown
uncompress_inline() is silently dropping an error from btrfs_decompress() after testing it and zeroing the page that was supposed to hold decompressed data. This can silently turn compressed inline data in to zeros if decompression fails due to corrupt compressed data or memory allocation failure.