Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-27 Thread Christoph Hellwig
On Mon, Apr 27, 2015 at 03:41:33PM +1000, NeilBrown wrote: > Are you sure about NFSv4.2? > > I see that it *can* report holes, but is there any guarantee that if you > create a new file and write only the 5th block, then READ_PLUS will reliably > report that the first 4 block are holes?? FYI, I'm

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-26 Thread NeilBrown
On Mon, 20 Apr 2015 02:48:55 -0700 Christoph Hellwig wrote: > On Mon, Apr 20, 2015 at 10:46:49AM +0100, David Howells wrote: > > NeilBrown wrote: > > > > > Missing patch 2 of the 3-patch series? > > > > Yes. :-) > > > > Do ext4 and xfs support this, do you know? > > Yes. As do f2fs, ocfs2,

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-21 Thread Hugh Dickins
On Tue, 21 Apr 2015, Christoph Hellwig wrote: > On Mon, Apr 20, 2015 at 01:58:35PM +0100, Al Viro wrote: > > > > Do ext4 and xfs support this, do you know? > > > > > > Yes. As do f2fs, ocfs2, gfs2, ceph and NFSv4.2 > > > > Er... Nominally, gfs2 supports it. By treating all files as "there's a

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-21 Thread Christoph Hellwig
On Mon, Apr 20, 2015 at 01:58:35PM +0100, Al Viro wrote: > > > Do ext4 and xfs support this, do you know? > > > > Yes. As do f2fs, ocfs2, gfs2, ceph and NFSv4.2 > > Er... Nominally, gfs2 supports it. By treating all files as "there's a > hole starting at EOF". Same as ext2 or even minix... Y

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-20 Thread Chris Mason
On 04/20/2015 01:27 AM, NeilBrown wrote: > This allows fscache to cachefiles in a btrfs filesystem. Thanks for working on this Neil. Signed-off-by: Chris Mason -chris > > Signed-off-by: NeilBrown > --- > fs/btrfs/super.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-20 Thread Al Viro
On Mon, Apr 20, 2015 at 02:48:55AM -0700, Christoph Hellwig wrote: > On Mon, Apr 20, 2015 at 10:46:49AM +0100, David Howells wrote: > > NeilBrown wrote: > > > > > Missing patch 2 of the 3-patch series? > > > > Yes. :-) > > > > Do ext4 and xfs support this, do you know? > > Yes. As do f2fs, oc

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-20 Thread Christoph Hellwig
On Mon, Apr 20, 2015 at 10:46:49AM +0100, David Howells wrote: > NeilBrown wrote: > > > Missing patch 2 of the 3-patch series? > > Yes. :-) > > Do ext4 and xfs support this, do you know? Yes. As do f2fs, ocfs2, gfs2, ceph and NFSv4.2 > > David ---end quoted text--- -- To unsubscribe from th

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-20 Thread David Howells
NeilBrown wrote: > Missing patch 2 of the 3-patch series? Yes. :-) Do ext4 and xfs support this, do you know? David -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/maj

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-20 Thread NeilBrown
On Mon, 20 Apr 2015 09:47:42 +0100 David Howells wrote: > NeilBrown wrote: > > > + .fs_flags = FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA | > > + FS_SUPPORTS_SEEK_HOLE, > > I must be missing something: > > warthog>git merge linus/master > Already up-to-date.

Re: [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-20 Thread David Howells
NeilBrown wrote: > + .fs_flags = FS_REQUIRES_DEV | FS_BINARY_MOUNTDATA | > + FS_SUPPORTS_SEEK_HOLE, I must be missing something: warthog>git merge linus/master Already up-to-date. warthog>stg id 09d51602cf84a1264946711dd4ea0dddbac5

[PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag.

2015-04-19 Thread NeilBrown
This allows fscache to cachefiles in a btrfs filesystem. Signed-off-by: NeilBrown --- fs/btrfs/super.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 05fef198ff94..d3c5d2b40f8e 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.