Re: [PATCH 3/4] btrfs-progs: replace a confusing raw number with a macro

2014-07-29 Thread Gui Hecheng
On Tue, 2014-07-29 at 14:19 +0200, David Sterba wrote: > On Tue, Jul 29, 2014 at 02:16:14PM +0200, David Sterba wrote: > > On Thu, Jul 17, 2014 at 10:40:38AM +0800, Gui Hecheng wrote: > > > The raw number 36 for the uuid string length is somewhat confusing, > > > use a macro to define replace it. >

Re: [PATCH 3/4] btrfs-progs: replace a confusing raw number with a macro

2014-07-29 Thread David Sterba
On Tue, Jul 29, 2014 at 02:16:14PM +0200, David Sterba wrote: > On Thu, Jul 17, 2014 at 10:40:38AM +0800, Gui Hecheng wrote: > > The raw number 36 for the uuid string length is somewhat confusing, > > use a macro to define replace it. > > There's the BTRFS_UUID_UNPARSED_SIZE macro, please use it i

Re: [PATCH 3/4] btrfs-progs: replace a confusing raw number with a macro

2014-07-29 Thread David Sterba
On Thu, Jul 17, 2014 at 10:40:38AM +0800, Gui Hecheng wrote: > The raw number 36 for the uuid string length is somewhat confusing, > use a macro to define replace it. There's the BTRFS_UUID_UNPARSED_SIZE macro, please use it instead to avoid duplicate definitions. -- To unsubscribe from this list:

[PATCH 3/4] btrfs-progs: replace a confusing raw number with a macro

2014-07-16 Thread Gui Hecheng
The raw number 36 for the uuid string length is somewhat confusing, use a macro to define replace it. Signed-off-by: Gui Hecheng --- cmds-scrub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmds-scrub.c b/cmds-scrub.c index a604b25..03eb9ba 100644 --- a/cmds-scrub.c ++