Re: [PATCH 4/4] Btrfs: remove no longer needed range length checks for deduplication

2019-02-18 Thread David Sterba
On Thu, Jan 31, 2019 at 04:31:49PM +, Filipe Manana wrote: > On Wed, Dec 12, 2018 at 6:07 PM wrote: > > > > From: Filipe Manana > > > > Comparing the content of the pages in the range to deduplicate is now done > > by the generic helper generic_remap_file_range_prep(), which takes care of > >

Re: [PATCH 4/4] Btrfs: remove no longer needed range length checks for deduplication

2019-02-12 Thread Filipe Manana
On Thu, Jan 31, 2019 at 4:31 PM Filipe Manana wrote: > > On Wed, Dec 12, 2018 at 6:07 PM wrote: > > > > From: Filipe Manana > > > > Comparing the content of the pages in the range to deduplicate is now done > > by the generic helper generic_remap_file_range_prep(), which takes care of > > ensuri

Re: [PATCH 4/4] Btrfs: remove no longer needed range length checks for deduplication

2019-01-31 Thread Filipe Manana
On Wed, Dec 12, 2018 at 6:07 PM wrote: > > From: Filipe Manana > > Comparing the content of the pages in the range to deduplicate is now done > by the generic helper generic_remap_file_range_prep(), which takes care of > ensuring we do not compare/deduplicate undefined data beyond a file's eof >

Re: [PATCH 4/4] Btrfs: remove no longer needed range length checks for deduplication

2018-12-13 Thread Nikolay Borisov
On 12.12.18 г. 20:05 ч., fdman...@kernel.org wrote: > From: Filipe Manana > > Comparing the content of the pages in the range to deduplicate is now done > by the generic helper generic_remap_file_range_prep(), which takes care of very minor nit: the checks are performed in generic_remap_check

[PATCH 4/4] Btrfs: remove no longer needed range length checks for deduplication

2018-12-12 Thread fdmanana
From: Filipe Manana Comparing the content of the pages in the range to deduplicate is now done by the generic helper generic_remap_file_range_prep(), which takes care of ensuring we do not compare/deduplicate undefined data beyond a file's eof (range from eof to the next block boundary). So remov