[PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-17 Thread Josef Bacik
Ext4 doesn't have the ability to punch holes yet, so make sure we return EOPNOTSUPP if we try to use hole punching through fallocate. This support can be added later. Thanks, Acked-by: Jan Kara j...@suse.cz Signed-off-by: Josef Bacik jo...@redhat.com --- fs/ext4/extents.c |4 1 files

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-16 Thread Jan Kara
On Mon 15-11-10 12:05:21, Josef Bacik wrote: Ext4 doesn't have the ability to punch holes yet, so make sure we return EOPNOTSUPP if we try to use hole punching through fallocate. This support can be added later. Thanks, Signed-off-by: Josef Bacik jo...@redhat.com Acked-by: Jan Kara

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-16 Thread Avi Kivity
On 11/15/2010 07:05 PM, Josef Bacik wrote: Ext4 doesn't have the ability to punch holes yet, so make sure we return EOPNOTSUPP if we try to use hole punching through fallocate. This support can be added later. Thanks, Instead of teaching filesystems to fail if they don't support the

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-16 Thread Josef Bacik
On Tue, Nov 16, 2010 at 02:25:35PM +0200, Avi Kivity wrote: On 11/15/2010 07:05 PM, Josef Bacik wrote: Ext4 doesn't have the ability to punch holes yet, so make sure we return EOPNOTSUPP if we try to use hole punching through fallocate. This support can be added later. Thanks, Instead

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-16 Thread Avi Kivity
On 11/16/2010 02:50 PM, Josef Bacik wrote: On Tue, Nov 16, 2010 at 02:25:35PM +0200, Avi Kivity wrote: On 11/15/2010 07:05 PM, Josef Bacik wrote: Ext4 doesn't have the ability to punch holes yet, so make sure we return EOPNOTSUPP if we try to use hole punching through fallocate. This

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-16 Thread Pádraig Brady
On 15/11/10 17:05, Josef Bacik wrote: Ext4 doesn't have the ability to punch holes yet, so make sure we return EOPNOTSUPP if we try to use hole punching through fallocate. This support can be added later. Thanks, Signed-off-by: Josef Bacik jo...@redhat.com --- fs/ext4/extents.c |4

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-16 Thread Josef Bacik
On Tue, Nov 16, 2010 at 04:20:43PM +, Pádraig Brady wrote: On 15/11/10 17:05, Josef Bacik wrote: Ext4 doesn't have the ability to punch holes yet, so make sure we return EOPNOTSUPP if we try to use hole punching through fallocate. This support can be added later. Thanks,

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-16 Thread Greg Freemyer
On Tue, Nov 16, 2010 at 8:05 AM, Josef Bacik jo...@redhat.com wrote: On Tue, Nov 16, 2010 at 03:07:29PM +0200, Avi Kivity wrote: On 11/16/2010 02:50 PM, Josef Bacik wrote: On Tue, Nov 16, 2010 at 02:25:35PM +0200, Avi Kivity wrote:  On 11/15/2010 07:05 PM, Josef Bacik wrote:  Ext4 doesn't

Re: [PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-16 Thread Josef Bacik
On Tue, Nov 16, 2010 at 10:06:40PM -0500, Ted Ts'o wrote: There is no simple way to test if a filesystem supports hole punching or not so the check has to be done per fs. Thanks, Could put a flag word in superblock_operations. Filesystems which support punching (or other features)

[PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-15 Thread Josef Bacik
Ext4 doesn't have the ability to punch holes yet, so make sure we return EOPNOTSUPP if we try to use hole punching through fallocate. This support can be added later. Thanks, Signed-off-by: Josef Bacik jo...@redhat.com --- fs/ext4/extents.c |4 1 files changed, 4 insertions(+), 0

[PATCH 4/6] Ext4: fail if we try to use hole punch

2010-11-08 Thread Josef Bacik
Ext4 doesn't have the ability to punch holes yet, so make sure we return EOPNOTSUPP if we try to use hole punching through fallocate. This support can be added later. Thanks, Signed-off-by: Josef Bacik jo...@redhat.com --- fs/ext4/extents.c |4 1 files changed, 4 insertions(+), 0