Re: [PATCH 5/5] Btrfs: kill obsolete arguments in btrfs_wait_ordered_extents

2012-09-14 Thread Josef Bacik
On Fri, Sep 14, 2012 at 02:58:07AM -0600, Liu Bo wrote: nocow_only is now an obsolete argument. Why is it obsolete, it looks like it's being used to me? Thanks, Josef -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org

Re: [PATCH 5/5] Btrfs: kill obsolete arguments in btrfs_wait_ordered_extents

2012-09-14 Thread Liu Bo
On 09/14/2012 08:45 PM, Josef Bacik wrote: On Fri, Sep 14, 2012 at 02:58:07AM -0600, Liu Bo wrote: nocow_only is now an obsolete argument. Why is it obsolete, it looks like it's being used to me? Thanks, All of its callers use 0 as nocow_only now. thanks, liubo Josef -- To

Re: [PATCH 5/5] Btrfs: kill obsolete arguments in btrfs_wait_ordered_extents

2012-09-14 Thread Josef Bacik
On Fri, Sep 14, 2012 at 06:55:23AM -0600, Liu Bo wrote: On 09/14/2012 08:45 PM, Josef Bacik wrote: On Fri, Sep 14, 2012 at 02:58:07AM -0600, Liu Bo wrote: nocow_only is now an obsolete argument. Why is it obsolete, it looks like it's being used to me? Thanks, All of its callers

Re: [PATCH 5/5] Btrfs: kill obsolete arguments in btrfs_wait_ordered_extents

2012-09-14 Thread David Sterba
On Fri, Sep 14, 2012 at 08:45:16AM -0400, Josef Bacik wrote: On Fri, Sep 14, 2012 at 02:58:07AM -0600, Liu Bo wrote: nocow_only is now an obsolete argument. Why is it obsolete, it looks like it's being used to me? Thanks, It's always 0 so the removed code never executes. I'm tracking