On Thu, Jan 29, 2015 at 01:37:58PM +0100, David Sterba wrote:
Adding Al Viro into CC
On Thu, Jan 29, 2015 at 10:24:39AM +0800, Qu Wenruo wrote:
+struct vfsmount *get_vfsmount_sb(struct super_block *sb)
+{
+ struct vfsmount *ret_vfs = NULL;
+ struct mount *mnt;
+ int ret = 0;
Adding Al Viro into CC
On Thu, Jan 29, 2015 at 10:24:39AM +0800, Qu Wenruo wrote:
+struct vfsmount *get_vfsmount_sb(struct super_block *sb)
+{
+ struct vfsmount *ret_vfs = NULL;
+ struct mount *mnt;
+ int ret = 0;
+
+ lock_mount_hash();
+ if (list_empty(sb-s_mounts))
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Al Viro v...@zeniv.linux.org.uk
To: dste...@suse.cz, Qu Wenruo quwen...@cn.fujitsu.com,
linux-btrfs@vger.kernel.org, linux-fsdevel linux-fsde
On Fri, Jan 30, 2015 at 09:44:03AM +0800, Qu Wenruo wrote:
This shouldn't happen. If someone is ro, the whole fs should be ro, right?
Wrong. Individual vfsmounts over an r/w superblock might very well be r/o.
As for that trylock... What for? It invites transient failures for no
good reason.
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Al Viro v...@zeniv.linux.org.uk
To: Qu Wenruo quwen...@cn.fujitsu.com
Date: 2015年01月30日 10:09
On Fri, Jan 30, 2015 at 09:11:26AM +0800, Qu Wenruo
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Qu Wenruo quwen...@cn.fujitsu.com
To: Miao Xie miao...@huawei.com, linux-btrfs@vger.kernel.org
Date: 2015年01月30日 09:44
Original Message
On Fri, Jan 30, 2015 at 09:11:26AM +0800, Qu Wenruo wrote:
For the mounted ro case, that's not a problem, since if one instance
is mounted ro,
other instances are also mounted ro, so that's not a problem.
Not really.
root@satch:~# cd /tmp/
root@satch:~# mkdir /tm/a
root@satch:~# mount --bind
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Miao Xie miao...@huawei.com
To: Al Viro v...@zeniv.linux.org.uk, Qu Wenruo quwen...@cn.fujitsu.com
Date: 2015年01月30日 12:14
On Fri, 30 Jan 2015 02:14
On Fri, Jan 30, 2015 at 12:14:24PM +0800, Miao Xie wrote:
On Fri, 30 Jan 2015 02:14:45 +, Al Viro wrote:
On Fri, Jan 30, 2015 at 09:44:03AM +0800, Qu Wenruo wrote:
This shouldn't happen. If someone is ro, the whole fs should be ro, right?
Wrong. Individual vfsmounts over an r/w
On Fri, 30 Jan 2015 04:37:14 +, Al Viro wrote:
On Fri, Jan 30, 2015 at 12:14:24PM +0800, Miao Xie wrote:
On Fri, 30 Jan 2015 02:14:45 +, Al Viro wrote:
On Fri, Jan 30, 2015 at 09:44:03AM +0800, Qu Wenruo wrote:
This shouldn't happen. If someone is ro, the whole fs should be ro, right?
On Fri, 30 Jan 2015 10:02:26 +0800, Qu Wenruo wrote:
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function to get
vfsmount from a given sb.
From: Qu Wenruo quwen...@cn.fujitsu.com
To: Miao Xie miao...@huawei.com, linux-btrfs
On Fri, 30 Jan 2015 02:14:45 +, Al Viro wrote:
On Fri, Jan 30, 2015 at 09:44:03AM +0800, Qu Wenruo wrote:
This shouldn't happen. If someone is ro, the whole fs should be ro, right?
Wrong. Individual vfsmounts over an r/w superblock might very well be r/o.
As for that trylock... What
On Fri, Jan 30, 2015 at 01:34:41PM +0800, Miao Xie wrote:
First of all, -s_umount is not a mutex; it's rwsem. So you mean
down_read_trylock(). As for the transient failures - grep for down_write
on it... E.g. have somebody call mount() from the same device. We call
sget(), which
On Thu, 29 Jan 2015 10:24:39 +0800, Qu Wenruo wrote:
There are sysfs interfaces in some fs, only btrfs yet, which will modify
on-disk data.
Unlike normal file operation routine we can use mnt_want_write_file() to
protect the operation, change through sysfs won't to be binded to any file
in
Original Message
Subject: Re: [PATCH RESEND v4 6/8] vfs: Add get_vfsmount_sb() function
to get vfsmount from a given sb.
From: Miao Xie miao...@huawei.com
To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org
Date: 2015年01月30日 08:52
On Thu, 29 Jan 2015 10:24:39
There are sysfs interfaces in some fs, only btrfs yet, which will modify
on-disk data.
Unlike normal file operation routine we can use mnt_want_write_file() to
protect the operation, change through sysfs won't to be binded to any file
in the filesystem.
So we can only extract the first vfsmount of
16 matches
Mail list logo