Re: [PATCH RFC] vfs: add mount umount logs

2017-05-24 Thread Anand Jain
Thanks for comments. But that said, I find the log spam today from e.g. docker + devicemapper + xfs annoying, and switching to overlay2 fixed that as a side effect which is nice. Having overlay2 log would reintroduce that problem. You are right, docker with overlay2 logs additional 6 lines

Re: [PATCH RFC] vfs: add mount umount logs

2017-05-24 Thread Anand Jain
Thanks for the comments. On 05/19/2017 11:01 PM, Theodore Ts'o wrote: On Fri, May 19, 2017 at 08:17:55AM +0800, Anand Jain wrote: XFS already logs its own unmounts. Nice. as far as I know its only in XFS. Ext4 logs mounts, but not unmounts. I prefer to let each filesystem log its own

Re: [PATCH RFC] vfs: add mount umount logs

2017-05-19 Thread Colin Walters
On Thu, May 18, 2017, at 06:08 AM, Anand Jain wrote: > By looking at the logs we should be able to know when was the FS > mounted and unmounted and the options used, so to help forensic > investigations. Worth noting here that systemd already tracks mounts (via monitoring /proc/self/mountinfo)

Re: [PATCH RFC] vfs: add mount umount logs

2017-05-19 Thread Theodore Ts'o
On Fri, May 19, 2017 at 08:17:55AM +0800, Anand Jain wrote: > > XFS already logs its own unmounts. > > Nice. as far as I know its only in XFS. Ext4 logs mounts, but not unmounts. > > I prefer to let each filesystem log > > its own unmount, because then the mount/unmount messages also have the

Re: [PATCH RFC] vfs: add mount umount logs

2017-05-18 Thread Anand Jain
On 05/19/2017 01:39 AM, Darrick J. Wong wrote: On Thu, May 18, 2017 at 06:08:04PM +0800, Anand Jain wrote: By looking at the logs we should be able to know when was the FS mounted and unmounted and the options used, so to help forensic investigations. Signed-off-by: Anand Jain

Re: [PATCH RFC] vfs: add mount umount logs

2017-05-18 Thread Anand Jain
On 05/18/2017 08:23 PM, Carlos Maiolino wrote: On Thu, May 18, 2017 at 06:08:04PM +0800, Anand Jain wrote: By looking at the logs we should be able to know when was the FS mounted and unmounted and the options used, so to help forensic investigations. Signed-off-by: Anand Jain

Re: [PATCH RFC] vfs: add mount umount logs

2017-05-18 Thread Darrick J. Wong
On Thu, May 18, 2017 at 06:08:04PM +0800, Anand Jain wrote: > By looking at the logs we should be able to know when was the FS > mounted and unmounted and the options used, so to help forensic > investigations. > > Signed-off-by: Anand Jain > --- > You may want to know

Re: [PATCH RFC] vfs: add mount umount logs

2017-05-18 Thread Carlos Maiolino
On Thu, May 18, 2017 at 06:08:04PM +0800, Anand Jain wrote: > By looking at the logs we should be able to know when was the FS > mounted and unmounted and the options used, so to help forensic > investigations. > > Signed-off-by: Anand Jain > --- > You may want to know

[PATCH RFC] vfs: add mount umount logs

2017-05-18 Thread Anand Jain
By looking at the logs we should be able to know when was the FS mounted and unmounted and the options used, so to help forensic investigations. Signed-off-by: Anand Jain --- You may want to know that, during boot and shutdown this adds roughly 25 lines more logs depending