Re: [PATCH RFC 0/2] Btrfs: fix file data corruptions due to lost dirty bits

2018-06-25 Thread Chris Mason
On 25 Jun 2018, at 7:10, David Sterba wrote: On Fri, Jun 22, 2018 at 05:25:54PM -0400, Chris Mason wrote: The bug came here: commit a528a24150870c5c16cbbbec69dba7e992b08456 Author: Souptick Joarder Date: Wed Jun 6 19:54:44 2018 +0530 btrfs: change return type of btrfs_page_mkwrite to

Re: [PATCH RFC 0/2] Btrfs: fix file data corruptions due to lost dirty bits

2018-06-25 Thread David Sterba
On Fri, Jun 22, 2018 at 05:25:54PM -0400, Chris Mason wrote: > The bug came here: > > commit a528a24150870c5c16cbbbec69dba7e992b08456 > Author: Souptick Joarder > Date: Wed Jun 6 19:54:44 2018 +0530 > > btrfs: change return type of btrfs_page_mkwrite to vm_fault_t > > When page->mapping

Re: [PATCH RFC 0/2] Btrfs: fix file data corruptions due to lost dirty bits

2018-06-22 Thread Chris Mason
On 20 Jun 2018, at 16:24, David Sterba wrote: On Wed, Jun 20, 2018 at 03:48:08PM -0400, Chris Mason wrote: generic/095 [18:07:03][ 3769.317862] run fstests generic/095 at 2018-06-20 18:07:03 Hmpf, I pass both 095 and 208 here. [ 3774.849685] BTRFS: device fsid

Re: [PATCH RFC 0/2] Btrfs: fix file data corruptions due to lost dirty bits

2018-06-21 Thread Chris Mason
On 20 Jun 2018, at 15:33, David Sterba wrote: On Wed, Jun 20, 2018 at 07:56:10AM -0700, Chris Mason wrote: We've been hunting the root cause of data crc errors here at FB for a while. We'd find one or two corrupted files, usually displaying crc errors without any corresponding IO errors

Re: [PATCH RFC 0/2] Btrfs: fix file data corruptions due to lost dirty bits

2018-06-20 Thread David Sterba
On Wed, Jun 20, 2018 at 03:48:08PM -0400, Chris Mason wrote: > > > On 20 Jun 2018, at 15:33, David Sterba wrote: > > > On Wed, Jun 20, 2018 at 07:56:10AM -0700, Chris Mason wrote: > >> We've been hunting the root cause of data crc errors here at FB for a > >> while. > >> We'd find one or two

Re: [PATCH RFC 0/2] Btrfs: fix file data corruptions due to lost dirty bits

2018-06-20 Thread Chris Mason
On 20 Jun 2018, at 15:33, David Sterba wrote: On Wed, Jun 20, 2018 at 07:56:10AM -0700, Chris Mason wrote: We've been hunting the root cause of data crc errors here at FB for a while. We'd find one or two corrupted files, usually displaying crc errors without any corresponding IO errors

Re: [PATCH RFC 0/2] Btrfs: fix file data corruptions due to lost dirty bits

2018-06-20 Thread David Sterba
On Wed, Jun 20, 2018 at 07:56:10AM -0700, Chris Mason wrote: > We've been hunting the root cause of data crc errors here at FB for a while. > We'd find one or two corrupted files, usually displaying crc errors without > any > corresponding IO errors from the storage. The bug was rare enough that

[PATCH RFC 0/2] Btrfs: fix file data corruptions due to lost dirty bits

2018-06-20 Thread Chris Mason
We've been hunting the root cause of data crc errors here at FB for a while. We'd find one or two corrupted files, usually displaying crc errors without any corresponding IO errors from the storage. The bug was rare enough that we'd need to watch a large number of machines for a few days just to